Skip to content

[Cosmos] Remove unused files #11388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2020
Merged

[Cosmos] Remove unused files #11388

merged 2 commits into from
May 13, 2020

Conversation

southpolesteve
Copy link
Contributor

  • Remove unused murmur hash and consistent hashing ring files
  • Run local tests against proper emulator port

@southpolesteve southpolesteve requested a review from shurd as a code owner May 12, 2020 19:11
southpolesteve
southpolesteve commented May 12, 2020
View reviewed changes
sdk/cosmos/azure-cosmos/test/test_config.py
@@ -39,7 +39,7 @@ class _test_config(object):

#[SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Cosmos DB Emulator Key")]
masterKey = os.getenv('ACCOUNT_KEY', 'C2y6yDjf5/R+ob0N8A7Cgv30VRDJIWEHLM+4QDU5DE2nQ9nDuVTqobD4b8mGGyPMbIZnqyMsEcaGQy67XIw/Jw==')
host = os.getenv('ACCOUNT_HOST', 'https://localhost:443/')
host = os.getenv('ACCOUNT_HOST', 'https://localhost:8081/')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal emulator uses 443. This change runs the tests against the public emulator on 8081

southpolesteve
southpolesteve commented May 12, 2020
View reviewed changes
sdk/cosmos/azure-cosmos/test/test_crud.py
@@ -917,59 +915,6 @@ def test_document_crud(self):
replaced_document['id'],
replaced_document['id'])

def test_murmur_hash(self):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is tested but does not appear to be used in any application code

@southpolesteve southpolesteve requested a review from annatisch May 12, 2020 19:13
@annatisch
Copy link
Member

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@southpolesteve
Copy link
Contributor Author

@annatisch What's the difference between the tests that ran when I opened the PR and the ones that ran when you triggered the pipeline via the bot?

@annatisch
Copy link
Member

@southpolesteve - it should be live vs emulator.
However it looks like there's currently an issue without our engineering system (the OSName error). I will re-trigger once that's been resolved on our side :)

@annatisch
Copy link
Member

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

annatisch
annatisch approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Love removing code.... :)

@southpolesteve southpolesteve merged commit e2e5295 into Azure:master May 13, 2020
@southpolesteve southpolesteve deleted the remove-old-files branch May 13, 2020 18:40
iscai-msft added a commit that referenced this pull request May 13, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
527ec28 
…into move_get_client_for

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [Cosmos] Remove unused files (#11388)
  Sync eng/common directory with azure-sdk-tools repository (#11417)
  [form recognizer] consistency renames for FormTrainingClient (#11390)
  Release for azure mgmt eventhub (#11403)
  Network 2020 04 01 (#11405)
  link in to reference docs for sub-clients (#11396)
  Persistent caching for interactive credentials on Linux and macOS (#11319)
  [formrecognizer] add AAD auth support (#11275)
  Search docs/readme updates (#11391)
  Sync eng/common directory with azure-sdk-tools repository (#11387)
  Update tests for msal 1.3.0 (#11307)
iscai-msft added a commit that referenced this pull request May 18, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
4448f01 
…into feature/text_analytics_v3.0

* 'master' of https://github.com/Azure/azure-sdk-for-python: (128 commits)
  add more content to index crud samples (#11443)
  Add a snippet to the Samples readme mirroring the core readme, guiding users to the currently mainline version of the lib if the end up on the wrong page. (#11420)
  20200515 run resource live test (#11454)
  Release azure mgmt eventgrid (#11431)
  Smoke Tests use new workflow for package install (#11438)
  ServiceFabric 7.1 (#11451)
  update (#11424)
  Typing for appconfiguration (#11427)
  [form recognizer] Move `get_client` method from FormRecognizer -> FormTraining (#11423)
  release customvision (#11428)
  Enforce https in search (#11337)
  [Cosmos] Remove unused files (#11388)
  Sync eng/common directory with azure-sdk-tools repository (#11417)
  [form recognizer] consistency renames for FormTrainingClient (#11390)
  Release for azure mgmt eventhub (#11403)
  Network 2020 04 01 (#11405)
  link in to reference docs for sub-clients (#11396)
  Persistent caching for interactive credentials on Linux and macOS (#11319)
  [formrecognizer] add AAD auth support (#11275)
  Search docs/readme updates (#11391)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch annatisch approved these changes

@shurd shurd Awaiting requested review from shurd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@southpolesteve @annatisch @stfaul