Skip to content

track2 - servicebus - flaky test and documentation improvements for preview 3 #11740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2020
Merged

track2 - servicebus - flaky test and documentation improvements for preview 3 #11740

merged 2 commits into from
Jun 3, 2020

Conversation

KieranBrantnerMagee
Copy link
Member

  • Fix flaky tests to be more robust by adding dynamic expiry timers, remove reliance on message abandon ordering, and add additional test for session message error handling.
  • Additionally adds a helpful note to the README on how to handle autolockrenew failure in response to customer feedback; and a note in the migration guide about message datetime timezone and naming changes.

@KieranBrantnerMagee
Fix flaky tests to be more robust by adding dynamic expiry timers, re…
3773bfe 
…move reliance on message abandon ordering, and add additional test for session message error handling. Additionally adds a helpful note to the README on how to handle autolockrenew failure in response to customer feedback; and a note in the migration guide about message datetime timezone and naming changes.
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jun 1, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Jun 1, 2020
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
PR comments. Rename migration guide header and add additional sample …
3136a8c 
…for other object. Adjust test to use more normal constructs (iterator receive) and fix exception.
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling
yunhaoling approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KieranBrantnerMagee KieranBrantnerMagee merged commit 205a1cb into Azure:master Jun 3, 2020
@KieranBrantnerMagee KieranBrantnerMagee mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhaoling yunhaoling yunhaoling approved these changes

@annatisch annatisch Awaiting requested review from annatisch

@YijunXieMS YijunXieMS Awaiting requested review from YijunXieMS

Assignees

@KieranBrantnerMagee KieranBrantnerMagee

Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KieranBrantnerMagee @yunhaoling