Skip to content

[text analytics] Readme fix #11919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2020
Merged

[text analytics] Readme fix #11919

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83715b9
add whitespace in changelog
iscai-msft Jun 9, 2020
6027192
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python
iscai-msft Jun 9, 2020
72c0f6b
unified readme
iscai-msft Jun 9, 2020
4469d1c
keep aad sample with my-custom-subdomain
iscai-msft Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions sdk/textanalytics/azure-ai-textanalytics/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,11 @@ To create a client object, you will need the cognitive services or text analytic
your resource and a `credential` that allows you access:

```python
from azure.core.credentials import AzureKeyCredential
from azure.ai.textanalytics import TextAnalyticsClient

text_analytics_client = TextAnalyticsClient(endpoint="https://<region>.api.cognitive.microsoft.com/", credential=credential)
credential = AzureKeyCredential("<api_key>")
text_analytics_client = TextAnalyticsClient(endpoint="https://<region>.api.cognitive.microsoft.com/", credential=credential)
```

Note that if you create a [custom subdomain][cognitive_custom_subdomain]
Expand Down Expand Up @@ -117,14 +119,11 @@ AZURE_CLIENT_ID, AZURE_TENANT_ID, AZURE_CLIENT_SECRET

Use the returned token credential to authenticate the client:
```python
from azure.identity import DefaultAzureCredential
from azure.ai.textanalytics import TextAnalyticsClient
token_credential = DefaultAzureCredential()
from azure.identity import DefaultAzureCredential

text_analytics_client = TextAnalyticsClient(
endpoint="https://<my-custom-subdomain>.cognitiveservices.azure.com/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this specifically needs to be a custom subdomain to use AAD. why do you want to remove it? regional endpoint won't work

credential=token_credential
)
credential = DefaultAzureCredential()
text_analytics_client = TextAnalyticsClient(endpoint="https://<my-custom-subdomain>.api.cognitive.microsoft.com/", credential=credential)
```

## Key concepts
Expand Down