Merge SB management client to central repo dev branch #12205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 6, 2020 15:06
helper _convert_connection_string_to_kwargs
Update NamespaceProperties support, clean up ResponseTitle.
…or-python into sb_control_client
YijunXieMS
added
Service Bus
Client
YijunXieMS
requested review from
annatisch,
KieranBrantnerMagee and
yunhaoling
as code owners
yunhaoling
added a commit
that referenced
this pull request
Jul 2, 2020
… NamespaceProperties (#12227) * Since resource names can be programmatically constructed, add scrubber at base preparer level so as to ensure recordings get the real resource name swapped out with a consistent moniker. * In CI (but not locally) self.test_class_instance was not set before _preparer_wrapper is called, and thus self.is_live was failing. Since we have the test_class_instance, let's just use that. * Merge SB management client to central repo dev branch (#12205) * resource_moniker isn't guaranteed to be populated, so use moniker instead for default scrubbing strategy. Add remaining notes for how to run Keyvault tests to mgmt_settings_fake. * Update validation and type hints * Update models from swagger * Fix pylint * Fix update_subscription * Fix mypy errors * Remove start_index and max_page_size of list operations * add test and fix minor bugs * fix pylint * skip test of list with param and update recordings * Update msrest dependency to 0.6.17 * Fix code review feedback * Fix pylint and mypy error * Small fix type annotation * Do not call copy() in update_xxx * Update ivar * Link to swagger file in repo * clear queue/topic before the actual test Co-authored-by: Kieran Brantner-Magee <[email protected]> Co-authored-by: Adam Ling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.