Skip to content

[keyvault] add continuation token for key polling #12911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

iscai-msft
Copy link
Contributor

fixes #12027

For context: this PR is adding a continuation token functionality, so users can pickle their pollers and restart the polling from the state where they left off. These two pollers in key vault are also quite unique, the reason being that

  1. They're not defined as long running on the service side
  2. When we make the initial call to the service, the final response object, i.e. a deleted key is returned. However, it takes a while for the key to be fully deleted on the service side, so we poll until the service has fully deleted the key. We do allow users to immediately get the response object from the service though (our result function doesn't call wait)

@iscai-msft iscai-msft requested review from lmazuel and chlowell August 5, 2020 15:49
@iscai-msft iscai-msft requested a review from schaabs as a code owner August 5, 2020 15:49
@ghost ghost added the KeyVault label Aug 5, 2020
@iscai-msft iscai-msft changed the title [key vault] add continuation token for key polling [keyvault] add continuation token for key polling Aug 5, 2020
@iscai-msft iscai-msft requested a review from mccoyp September 14, 2020 19:04
@iscai-msft
Copy link
Contributor Author

closing, @mccoyp has his own PRs

@iscai-msft iscai-msft closed this Nov 16, 2020
@iscai-msft iscai-msft deleted the continuation_token_keys_2 branch November 16, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[keyvault] add continuation token to pollers in keys
1 participant