Skip to content

[T1] netapp 2020 11 16 #15279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2020
Merged

[T1] netapp 2020 11 16 #15279

merged 4 commits into from
Nov 16, 2020

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Nov 12, 2020

@msyyc msyyc requested a review from zikalino as a code owner November 12, 2020 02:56
@hildurhodd
Copy link
Contributor

hildurhodd commented Nov 12, 2020

@msyyc You are skipping a lot of tests. I have created a branch with generated sdk, azure-mgmt-netapp/0.14.0, and updated tests. Here is the branch: https://github.com/hildurhodd/azure-sdk-for-python/tree/netappfiles-tests-for-0-14-0
Unfortunately I can't create a pull request from mine to yours but I could create a PR from mine to Azure/release/v3 if you want.

Azure:release/v3 is still missing tests from previous version. I am waiting on a PR to be approved: #14806
I would be best to get them in before pushing azure-mgmt-netapp/0.14.0

@msyyc
Copy link
Member Author

msyyc commented Nov 13, 2020

@hildurhodd the framwork of test is not very good, I couldn't run live test directly. But I don't have enough time to improve it, so I have to skip some test. Now I have invited you to access my private repo(https://github.com/msyyc/azure-sdk-for-python), you could add test in branch(t1-netapp-2020-11-16). Thank you!

@hildurhodd
Copy link
Contributor

Tests have been added and broken ones updated. New recordings have been added with correct sdk versions.
All checks are now successful so this PR should be good to go.

@msyyc msyyc requested review from 00Kai0 and removed request for zikalino November 16, 2020 07:17
@msyyc msyyc merged commit 1d09bd7 into Azure:release/v3 Nov 16, 2020
@msyyc msyyc deleted the t1-netapp-2020-11-16 branch November 25, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants