[Perfstress][Storage] Added Blobs perf tests #15833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annatisch
requested review from
amishra-dev,
kasobol-msft,
rakshith91,
tasherif-msft,
xiafu-msft and
zezha-msft
as code owners
ghost
added
the
mikeharder
requested changes
Dec 21, 2020
tools/azure-devtools/src/azure_devtools/perfstress_tests/random_stream.py
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/tests/perfstress_tests/T1_legacy_tests/list_blobs.py
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/tests/perfstress_tests/T1_legacy_tests/upload.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/tests/perfstress_tests/T1_legacy_tests/upload_block.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/tests/perfstress_tests/T1_legacy_tests/upload_block.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/tests/perfstress_tests/upload.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/tests/perfstress_tests/upload_from_file.py
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/tests/perfstress_tests/upload_from_file.py
Show resolved
Hide resolved
mikeharder
approved these changes
Jan 11, 2021
tools/azure-devtools/src/azure_devtools/perfstress_tests/perf_stress_runner.py
Outdated
Show resolved
Hide resolved
tools/azure-devtools/src/azure_devtools/perfstress_tests/random_stream.py
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/tests/perfstress_tests/T1_legacy_tests/list_blobs.py
Show resolved
Hide resolved
| blob_name=self.blob_name, | ||
| stream=self.download_stream, | ||
| max_connections=self.args.max_concurrency) | ||
| self.download_stream.reset() |
There was a problem hiding this comment.
NIT: I prefer to reset before use, since it ensures you are working with a reset stream. But before or after are logically the same so whatever you prefer is also fine.
sdk/storage/azure-storage-blob/tests/perfstress_tests/T1_legacy_tests/list_blobs.py
Show resolved
Hide resolved
annatisch
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
tasherif-msft
approved these changes
Jan 26, 2021
sdk/storage/azure-storage-blob/tests/perfstress_tests/README.md
Outdated
Show resolved
Hide resolved
|
|
||
| def __init__(self, arguments): | ||
| super().__init__(arguments) | ||
| connection_string = self.get_from_env("AZURE_STORAGE_CONNECTION_STRING") |
There was a problem hiding this comment.
another minor nit: could we mention that its fetching the connection string from an env variable in the README?
There was a problem hiding this comment.
Great catch - forgot all about that!
Co-authored-by: tasherif-msft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.