-
Notifications
You must be signed in to change notification settings - Fork 3k
Update azure-core minimum version #16968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
craigktreasure
commented
Feb 26, 2021
- This change updates the minimum version of Azure Core to 1.4.0 to make sure we get a package version that includes AzureKeyCredential to fix the nightly release builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@seankane-msft Build failed with:
Any suggestions? |
cc83bae
to
efdd4a8
Compare
- This change updates the minimum version of Azure Core to 1.4.0 to make sure we get a package version that includes AzureKeyCredential to fix the nightly release builds.
efdd4a8
to
a739469
Compare
@craigktreasure I'll come up with something for you. This error doesn't make sense. |
Thanks @scbedd. Looks like that did the trick. Hopefully that version has everything I need. |
Hello @craigktreasure! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…into correct_healthcare * 'master' of https://github.com/Azure/azure-sdk-for-python: (30 commits) [EventGrid] Improve docs (Azure#16986) Fixed delete_blob method signature (Azure#16983) Fixed Content-MD5 serialization and typing (Azure#16987) [eventgrid] Black formatting and tests suite (Azure#16989) Appconfig perf test (Azure#16809) adds support for milliseconds on datetime objects (Azure#16847) [ServiceBus] Improve AMQP Error handling (Azure#16427) T2 resource 2021 02 26 (Azure#16961) T2 servicefabricmanagedclusters 2021 02 26 (Azure#16958) Update Prepare-Release script (Azure#16976) the previous filter was erroneously filtering out real files. (Azure#16978) Update azure-core minimum version (Azure#16968) update documention in depends section of eng_sys_checks.md (Azure#16967) version (Azure#16959) T2 web 2021 02 24 (Azure#16901) Change test pipeline to run in eastus2 (Azure#16950) Adding azure-devtools to mr-auth dev_requirements (Azure#16953) Add perf tests for eventgrid (Azure#16949) temp fix for canary tests (Azure#16945) Update get_package_properties to also return path to setup.py (Azure#16946) ...