[Tables] Updating EntityProperty #18177
Conversation
ghost
added
the
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
| @@ -226,7 +226,7 @@ def _add_entity_properties(source): | |||
| elif isinstance(value, datetime): | |||
| mtype, value = _to_entity_datetime(value) | |||
| elif isinstance(value, EntityProperty): | |||
| conv = _EDM_TO_ENTITY_CONVERSIONS.get(value.type) | |||
| conv = _EDM_TO_ENTITY_CONVERSIONS.get(value.edm_type) | |||
There was a problem hiding this comment.
We should remove the isinstance check, and instead treat this as a generic tuple....
elif isinstance(value, tuple): # ideally we wouldn't do the instance check at all here....
conv = _EDM_TO_ENTITY_CONVERSIONS.get(value[1])
...
mtype, value = conv(value[0])| entity.test2 = u'value' | ||
| entity.test3 = 3 | ||
| entity.test4 = EntityProperty(1234567890) | ||
| entity.test4 = EntityProperty(1234567890, EdmType.INT32) |
There was a problem hiding this comment.
Would be good to either add a test, or modify one of the existing ones to just use naked tuples:
entity.test4 = (1234567890, 'Edm.Int32')
|
/azp run python - tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…into azure_purview_catalog * 'master' of https://github.com/Azure/azure-sdk-for-python: (109 commits) [Tables] Adds support for AzureNamedKeyCredential (Azure#18456) [Tables] delete_entity takes an entity instead of row and partition key (Azure#18269) [Tables] Removed TableEntity attribute wrapper (Azure#18489) [EventHub&ServiceBus] Bump uAMQP dependency (Azure#17942) [ServiceBus] add keyword override support to update_ methods in mgmt module (Azure#18210) Add compatibility switch to disable CAE (Azure#18148) Service Bus Named Key Credential (Azure#18471) Change to use dynamic resource connection string for chat tests and identity samples (Azure#18502) Increase dependency (Azure#18500) show detailed error (Azure#18229) prerelease (Azure#18507) [Container Registry] addressing issues (Azure#18486) update per_call_policies & per_retry_policies (Azure#18406) Eh named key (Azure#18292) [Tables] Updating EntityProperty (Azure#18177) [Service Bus] fix async auth test (Azure#18499) [communication] Live Testing - Introduce CloudConfig into test.yml (Azure#18469) Release azure-servicefabric 8.0 (Azure#18488) [Communication]: Updated test_search_available_phone_numbers_with_invalid_country_code async test to be consistent with sync test (Azure#18466) [Container Registry] DeleteRepositoryResult Changed (Azure#18443) ...
typechanged toedm_type