[Tables] use etag from entity if match condition is given #18271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annatisch
reviewed
May 5, 2021
| if match_condition and not etag: | ||
| try: | ||
| etag = entity.metadata.get("etag", None) | ||
| except AttributeError: |
There was a problem hiding this comment.
I think you might also need to catch TypeError here - if a customer passes in a TableEntity instance they created, then entity.metadata will be None (and we should add a test for this).
There was a problem hiding this comment.
Updated and added a test!
sdk/tables/azure-data-tables/azure/data/tables/_table_client.py
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/azure/data/tables/aio/_table_client_async.py
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/azure/data/tables/aio/_table_client_async.py
Outdated
Show resolved
Hide resolved
| new_etag = e.metadata["etag"] | ||
| e.metadata["etag"] = old_etag | ||
|
|
||
| with pytest.raises(HttpResponseError): |
There was a problem hiding this comment.
Is this actually just a raw HttpResponseError? Or are we raising azure.core.ResourceModifiedError?
There was a problem hiding this comment.
This is a raw HttpResponseError, here's what it looks like.
E azure.core.exceptions.HttpResponseError: The update condition specified in the request was not satisfied.
E RequestId:0c9fe685-8002-003d-4cd4-41ac3f000000
E Time:2021-05-05T17:33:24.9865841Z
E ErrorCode:UpdateConditionNotSatisfied
There was a problem hiding this comment.
Interesting! I've made a note to fix that - but could come post-GA if needed.
annatisch
approved these changes
May 5, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 5, 2021
…into azure_purview_catalog * 'master' of https://github.com/Azure/azure-sdk-for-python: ignore analysis for swagger readmes (Azure#18520) [purview] add azure-purview-nspkg (Azure#18518) [AppConfiguration] Appconfig consistency (Azure#18493) [Container Registry] Improved samples (Azure#18263) [Container Registry] renamings (Azure#18492) [ServiceBus] internal code rename and sample readme update (Azure#18516) [EventHub] update link in sample readme (Azure#18517) Post Process Event Names Script (Azure#18419) [Tables] use etag from entity if match condition is given (Azure#18271) adding operation-location to headers that are scrubbed (Azure#18514)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 6, 2021
…into azure_purview_scanning * 'master' of https://github.com/Azure/azure-sdk-for-python: (550 commits) del useless files (Azure#18528) delete existing useless files for trafficmanager (Azure#18525) Define new replacer to replace keys in recording (Azure#18294) [purview] add purview nspkg to ci (Azure#18523) ignore analysis for swagger readmes (Azure#18520) [purview] add azure-purview-nspkg (Azure#18518) [AppConfiguration] Appconfig consistency (Azure#18493) [Container Registry] Improved samples (Azure#18263) [Container Registry] renamings (Azure#18492) [ServiceBus] internal code rename and sample readme update (Azure#18516) [EventHub] update link in sample readme (Azure#18517) Post Process Event Names Script (Azure#18419) [Tables] use etag from entity if match condition is given (Azure#18271) adding operation-location to headers that are scrubbed (Azure#18514) [Tables] Adds support for AzureNamedKeyCredential (Azure#18456) [Tables] delete_entity takes an entity instead of row and partition key (Azure#18269) [Tables] Removed TableEntity attribute wrapper (Azure#18489) [EventHub&ServiceBus] Bump uAMQP dependency (Azure#17942) [ServiceBus] add keyword override support to update_ methods in mgmt module (Azure#18210) Add compatibility switch to disable CAE (Azure#18148) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.