Skip to content

[AutoPR commerce/resource-manager] Add type and format specifiers on quantity property. #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2018
Merged

[AutoPR commerce/resource-manager] Add type and format specifiers on quantity property. #1975

merged 4 commits into from
Feb 22, 2018

Conversation

AutorestCI
Copy link
Contributor

@AutorestCI
Generated from d99a6326aac1fd99d9db17616669eba2f188b7ff
6a848e2 
Add type and format specifiers on quantity property.
@AutorestCI AutorestCI requested a review from lmazuel as a code owner February 13, 2018 21:56
@AutorestCI AutorestCI mentioned this pull request Feb 13, 2018
Merged
10 tasks
@codecov-io
Copy link

codecov-io commented Feb 13, 2018 •
edited
Loading

Codecov Report

Merging #1975 into restapi_auto_commerce/resource-manager will increase coverage by <.01%.
The diff coverage is 68.75%.

Impacted file tree graph

@@                            Coverage Diff                             @@
##           restapi_auto_commerce/resource-manager    #1975      +/-   ##
==========================================================================
+ Coverage                                   53.17%   53.17%   +<.01%     
==========================================================================
  Files                                        4714     4714              
  Lines                                      117148   117157       +9     
==========================================================================
+ Hits                                        62295    62301       +6     
- Misses                                      54853    54856       +3
Impacted Files Coverage Δ
.../azure/mgmt/commerce/models/monetary_commitment.py 55.55% <ø> (ø) ⬆️
...rce/azure/mgmt/commerce/models/recurring_charge.py 62.5% <ø> (ø) ⬆️
...erce/azure/mgmt/commerce/models/monetary_credit.py 100% <ø> (ø) ⬆️
...-commerce/azure/mgmt/commerce/models/info_field.py 66.66% <0%> (-13.34%) ⬇️
...merce/azure/mgmt/commerce/models/error_response.py 63.63% <0%> (-6.37%) ⬇️
...mgmt/commerce/models/rate_card_query_parameters.py 50% <0%> (-5.56%) ⬇️
...ce/azure/mgmt/commerce/models/usage_aggregation.py 20% <0%> (-1.06%) ⬇️
...erce/azure/mgmt/commerce/models/offer_term_info.py 100% <100%> (ø) ⬆️
...e/mgmt/commerce/operations/rate_card_operations.py 100% <100%> (ø) ⬆️
...re/mgmt/commerce/models/resource_rate_card_info.py 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80fc6f0...b08d925. Read the comment docs.

@lmazuel
Copy link
Member

lmazuel commented Feb 21, 2018

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/commerce/resource-manager/readme.md

@AutorestCI
Copy link
Contributor Author

Build SDK finished and cleaned

lmazuel
lmazuel reviewed Feb 21, 2018
View reviewed changes
azure-mgmt-commerce/azure/mgmt/commerce/models/usage_aggregation.py
@@ -62,7 +61,7 @@ class UsageAggregation(Model):
'meter_id': {'key': 'properties.meterId', 'type': 'str'},
'usage_start_time': {'key': 'properties.usageStartTime', 'type': 'iso-8601'},
'usage_end_time': {'key': 'properties.usageEndTime', 'type': 'iso-8601'},
'quantity': {'key': 'properties.quantity', 'type': 'object'},
'quantity': {'key': 'properties.quantity', 'type': 'float'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug fix

lmazuel
lmazuel reviewed Feb 21, 2018
View reviewed changes
azure-mgmt-commerce/azure/mgmt/commerce/operations/rate_card_operations.py
:ivar api_version: Client Api Version. Constant value: "2015-06-01-preview".
"""

models = models
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

models

lmazuel
lmazuel reviewed Feb 21, 2018
View reviewed changes
azure-mgmt-commerce/azure/mgmt/commerce/operations/usage_aggregates_operations.py
:ivar api_version: Client Api Version. Constant value: "2015-06-01-preview".
"""

models = models
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

models

@lmazuel
Copy link
Member

lmazuel commented Feb 22, 2018

Merge and release as 1.0.1

@lmazuel lmazuel merged commit 38b2ba6 into restapi_auto_commerce/resource-manager Feb 22, 2018
@lmazuel lmazuel deleted the restapi_auto_jhendrixMSFT_commerce branch February 22, 2018 00:52
@lmazuel lmazuel mentioned this pull request Feb 22, 2018
Merged
lmazuel added a commit that referenced this pull request Feb 22, 2018
@lmazuel
[AutoPR commerce/resource-manager] Add type and format specifiers on …
f896c05 
…quantity property. (#1975) (#2039)

* Generated from d99a6326aac1fd99d9db17616669eba2f188b7ff

Add type and format specifiers on quantity property.

* Rebuild by #1975

* Update packaging for azure-mgmt-commerce

* Migrate tests of azure-mgmt-commerce to new framework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel left review comments

Assignees
No one assigned
Labels
RestPRMerged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AutorestCI @codecov-io @lmazuel