Skip to content

Makes dev_setup.py script more portable #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Conversation

zooba
Copy link
Member

@zooba zooba commented Feb 27, 2018

This will avoid problems where pip on PATH does not map to the version of Python that the script was started with.

I believe the exec_command function is now unused, but didn't want to just delete it. LMK if you want it gone and I'll take it out.

@zooba zooba requested a review from lmazuel as a code owner February 27, 2018 17:26
@codecov-io
Copy link

codecov-io commented Feb 27, 2018

Codecov Report

Merging #2062 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2062   +/-   ##
=======================================
  Coverage   53.06%   53.06%           
=======================================
  Files        4774     4774           
  Lines      119483   119483           
=======================================
  Hits        63406    63406           
  Misses      56077    56077

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ecbcc0...472241a. Read the comment docs.

@lmazuel
Copy link
Member

lmazuel commented Feb 27, 2018

Thanks @zooba :). This was highly inspired by CLI, so they have the same issue (if you feel like PR it ;))

Yes, you can get rid of of exec_command if you have time. Thanks!

@lmazuel
Copy link
Member

lmazuel commented Feb 28, 2018

Thanks @zooba :)

@lmazuel lmazuel merged commit 98eae31 into Azure:master Feb 28, 2018
@zooba zooba deleted the vstsbuild branch February 28, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants