-
Notifications
You must be signed in to change notification settings - Fork 3k
[Cosmos] Infra: use Bicep for resource provisioning #24198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Removed some stuff * Looking at constructors * Updated request * Added client close * working client creation Co-authored-by: simorenoh <[email protected]>
database read works, but ignored exception is returned: Fatal error on SSL transport NoneType has no attribute 'send' (_loop._proactor.send) RuntimeError: Event loop is closed Unclosed connector/ connection
Added methods needed to use async with when initializing client, but logs output "Exception ignored... Runtime Error: Event loop is closed"
Move branch into local fork
missing upsert and other resources
missing read_all_items and both query methods for container class
Complete item CRUD functionality - only missing queries
Query functionality and container query methods
also fixed README and added examples_async
/azp run python - cosmos - tests |
No pipelines are associated with this pull request. |
Some nits and considerations but LGTM. |
/azp run python - cosmos - tests |
No pipelines are associated with this pull request. |
@benbp does @simorenoh need to make a nominal change to the Cosmos code path to trigger the CI to run the tests? |
@simorenoh does this resolve the live test failures or is this a stepping stone on that path? |
@tjprescott This is very much a stepping stone - right now the tests pipeline for Python was turned off such as to not keep incurring costs the way we were doing before, and while this initial setup did deploy resources for me locally we have yet to test it on the pipeline to see if it successfully runs the tests. I want to get this approved ASAP so I can keep iterating on this as needed to test it and get the final fixes in place as needed. |
This PR takes care of updating the Python Cosmos SDK to utilize Bicep to provision test resources. Also has changes to the test config files to ensure these changes work and that the Cosmos test pipelines can be enabled again.