Skip to content

[Test Proxy] Add methods for setting custom recording options #25460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jul 29, 2022

Description

Per the specifications here, this adds methods for setting custom recording options (one method for test function-level setting, and another for session-level setting).

This will get Python up to speed with the support added in Azure/azure-sdk-tools#3490, though it won't currently be usable with the latest test proxy tool version in /eng/common (see Azure/azure-sdk-tools#3699). Targeting tool version 1.0.0-dev.20220719.1 exposes the fix and gets things working as expected when specifying transport options.

@lynshi: this is the update that I mentioned this morning, which will allow you to provide certificates you need for Confidential Ledger tests 🙂

@scbedd for notifs

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

@mccoyp mccoyp added EngSys This issue is impacting the engineering system. test-enhancement labels Jul 29, 2022
@mccoyp mccoyp requested a review from scbedd July 29, 2022 00:55
@mccoyp mccoyp merged commit f7be268 into Azure:main Jul 29, 2022
@mccoyp mccoyp deleted the proxy-recording-options branch July 29, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system. test-enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants