Add Azure ML job CODEOWNERS #26644
Merged
Add Azure ML job CODEOWNERS #26644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyJ1
approved these changes
Oct 5, 2022
jsquire
reviewed
Oct 5, 2022
| @@ -119,6 +119,10 @@ | |||
| # PRLabel: %Local Endpoints | |||
| /sdk/ml/azure-ai-ml/azure/ai/ml/_local_endpoints/ @NonStatic2014 @arunsu @stanley-msft @JustinFirsching | |||
|
|
|||
| # PRLabel: %Job | |||
There was a problem hiding this comment.
This label is way too general. Can we please find a more specific label that better encapsulates this service?
There was a problem hiding this comment.
thanks for the comments, will modify in the future if too many pr requests
so far my team would own all pull requests related to jobs
There was a problem hiding this comment.
This makes repository automation and reporting difficult, as we use labels as identifiers for a lot of logic. Let's please adjust the label name to something more specific to this service.
There was a problem hiding this comment.
perfect. We should probably apply the same pattern to "Local Endpoints" as well to keep the pattern predictable
jsquire
added a commit
that referenced
this pull request
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines