Skip to content

[Storage] Hotfix for empty file download through Azurite #26897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jalauzon-msft
Copy link
Member

@jalauzon-msft jalauzon-msft commented Oct 18, 2022

This change cherry-picks two bug fixes from main into the hotfix branch for a patch release.

  • Fixes ValueError on empty blob download from Azurite for blob, datalake (calls into blob), and file-share.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Oct 18, 2022
@jalauzon-msft
Copy link
Member Author

/azp run python - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 18, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-blob
azure-storage-file-share
azure-storage-file-datalake

@jalauzon-msft jalauzon-msft changed the title [Storage] Hotfix for empty file download through Azurite and list_shares prefix issue [Storage] Hotfix for empty file download through Azurite Oct 18, 2022
@jalauzon-msft
Copy link
Member Author

/azp run python - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! That pesky 0, None, NULL, False mumbo jumbo that is usually handy in Python proved to not be so helpful here 😛

@jalauzon-msft jalauzon-msft merged commit 3988a10 into Azure:hotfix/storage-empty-download Oct 18, 2022
@jalauzon-msft jalauzon-msft deleted the hotfix-empty-blob branch October 18, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants