-
Notifications
You must be signed in to change notification settings - Fork 3k
Adding in some functionality to use different clouds #28528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f5657de
Adding in some functionality to use different clouds
brownma-ms 69523c4
Removing some of the functionality, only ARM check remains
brownma-ms 35d28ad
Adding unit test for new environments functionality
brownma-ms 69a5810
fixed tests with mock
ronaldshaw-work 0a461e8
removed print statement
ronaldshaw-work 0dcc7b2
removed commented code
ronaldshaw-work 4210a4e
removed print statements (oops)
ronaldshaw-work 53c7db0
fixed tests and removed comments
ronaldshaw-work 7fe48d2
Fixing a testing bug
brownma-ms f3939b2
Fixing a misspelled word
brownma-ms 215cf30
Changing how we reach out to ARM, als fixing some pylint
brownma-ms 571b4bb
Fixing more lint errors
brownma-ms f04d399
Fixing more lint errors
brownma-ms 2254a5b
updated code per suggestions in PR
ronaldshaw-work 22da338
fixed typo in warning
ronaldshaw-work 88586b1
added registry_endpoint to metadata url, also added tests for making …
ronaldshaw-work badc3a3
updated how the registry discovery endpoint is created. Uses a defaul…
ronaldshaw-work 390eeed
fixed linting errors
ronaldshaw-work 9ff796c
moved discovery url logic around to make sure it's not overwriting pu…
ronaldshaw-work 848a871
Fixing small pylint errors
brownma-ms 1ca9fec
Moving over to using HttpPipeline instead of requests
brownma-ms 55964d3
fixed up based on comments in the PR
ronaldshaw-work 88088df
merged in from origin
ronaldshaw-work ee52f13
fixed broken unit tests and mocked correctly
ronaldshaw-work f94358e
Fixing pylint issues
brownma-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.