Skip to content

[Monitor][Query] Add resource centric query support #29365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 6, 2023

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Mar 15, 2023

This regenerates with autorest and provides an API for users to query Azure Monitor logs directly from a resource instead of going through the context of a Log Analytics workspace.

This adds:

  • a new public method query_resource to both sync and async logs clients.
  • two new samples (sync/async)
  • updates to README
  • new tests

Closes #27522
Closes #20417

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-monitor-query

@pvaneck pvaneck force-pushed the query-resource-api branch from 55873f5 to 86e9b0f Compare March 15, 2023 23:00
@pvaneck pvaneck force-pushed the query-resource-api branch from 86e9b0f to 4086ff3 Compare March 27, 2023 22:19
pvaneck added 3 commits April 4, 2023 17:25
This regenerates with autorest and provides an API for
users to query Azure Monitor logs directly from a resource
instead of going through the context of a Log Analytics workspace.

Signed-off-by: Paul Van Eck <[email protected]>
Signed-off-by: Paul Van Eck <[email protected]>
@pvaneck pvaneck force-pushed the query-resource-api branch from 6f37d85 to f982841 Compare April 5, 2023 00:59
Signed-off-by: Paul Van Eck <[email protected]>
@pvaneck pvaneck force-pushed the query-resource-api branch from f982841 to d596ae4 Compare April 5, 2023 01:03
@pvaneck pvaneck requested a review from kristapratico April 5, 2023 22:57
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits. LGTM

This provides more context and makes the code more
copy/paste-able.

Signed-off-by: Paul Van Eck <[email protected]>
@pvaneck pvaneck merged commit 8a20de4 into Azure:main Apr 6, 2023
@pvaneck pvaneck deleted the query-resource-api branch April 6, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Monitor Query] Support resource-centric logs queries LogsQueryClient should be able to handle platform logs
3 participants