Skip to content

aiohttp multipart/form-data fix applied to corehttp #32581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2023
Merged

aiohttp multipart/form-data fix applied to corehttp #32581

merged 4 commits into from
Oct 20, 2023

Conversation

kristapratico
Copy link
Member

Resolves #32580

@kristapratico kristapratico requested a review from pvaneck October 19, 2023 18:58
pvaneck
pvaneck reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kristapratico. Looks like the failures are just the typical aiohttp pypy failures that's currently being investigated. The release pipeline didn't create a version increment PR for some reason. Mind also bumping the version in _version.py to make the changelog verification happy while I get that sorted?

@kristapratico
Copy link
Member Author

Thanks, @kristapratico. Looks like the failures are just the typical aiohttp pypy failures that's currently being investigated. The release pipeline didn't create a version increment PR for some reason. Mind also bumping the version in _version.py to make the changelog verification happy while I get that sorted?

done!

@kristapratico
Copy link
Member Author

/check-enforcer override

@kristapratico
Copy link
Member Author

tables, core, and containerregistry CI failures are unrelated to changes in this PR and same failures are found on the main build.

@kristapratico kristapratico merged commit 422388a into main Oct 20, 2023
@kristapratico kristapratico deleted the corehttp-aiohttp-multipart-formdata branch October 20, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvaneck pvaneck pvaneck approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@johanste johanste Awaiting requested review from johanste johanste is a code owner

Assignees
No one assigned
Labels
Core.Http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add aiohttp multipart/form-data fix to corehttp
2 participants
@kristapratico @pvaneck