Skip to content

[AutoPR] datamigration/resource-manager #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 5, 2018

Conversation

AutorestCI
Copy link
Contributor

Created to accumulate context: datamigration/resource-manager

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Oct 1, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-datamigration

You can install the package azure-mgmt-datamigration of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_datamigration/resource-manager#egg=azure-mgmt-datamigration&subdirectory=azure-mgmt-datamigration"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_datamigration/resource-manager#egg=azure-mgmt-datamigration&subdirectory=azure-mgmt-datamigration"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_datamigration/resource-manager
  • pip install -e ./azure-mgmt-datamigration

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_datamigration/resource-manager
  • pip wheel --no-deps ./azure-mgmt-datamigration

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #3475 into master will decrease coverage by 0.59%.
The diff coverage is 50.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3475      +/-   ##
==========================================
- Coverage   37.59%   36.99%    -0.6%     
==========================================
  Files        8789     9296     +507     
  Lines      266117   290284   +24167     
==========================================
+ Hits       100053   107400    +7347     
- Misses     166064   182884   +16820
Impacted Files Coverage Δ
...atamigration/models/project_task_properties_py3.py 55% <ø> (ø) ⬆️
...azure/mgmt/datamigration/models/connection_info.py 100% <ø> (ø) ⬆️
...ion/azure/mgmt/datamigration/models/project_py3.py 46.42% <ø> (ø) ⬆️
...mt/datamigration/models/project_task_properties.py 100% <ø> (ø) ⬆️
...e/mgmt/datamigration/models/connection_info_py3.py 55.55% <ø> (ø) ⬆️
...gration/azure/mgmt/datamigration/models/project.py 100% <ø> (ø) ⬆️
...migrate_schema_sql_server_sql_db_database_input.py 50% <0%> (-7.15%) ⬇️
...on/azure/mgmt/datamigration/operations/__init__.py 88.88% <100%> (+1.38%) ⬆️
...gmt/datamigration/data_migration_service_client.py 65% <100%> (-2.28%) ⬇️
...ration/azure/mgmt/datamigration/models/__init__.py 99.73% <100%> (+0.03%) ⬆️
... and 820 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea01fa...4d08779. Read the comment docs.

…project files resource and MongoDb scenario. (#3620)

* Generated from 15db3a1eb5955b63b419027978ceb13d1b8a421d

Add missing files upload option for Schema migration scenario.
Add support for MongoDb migration acenario.

* Packaging update of azure-mgmt-datamigration
@vchske
Copy link
Contributor

vchske commented Oct 26, 2018

Where does the version come from? What's being merged jumps backward and I don't think that's necessarily what we want to happen.

@vchske
Copy link
Contributor

vchske commented Oct 26, 2018

I think I see it coming from the spec's readme.md file (where autorest looks to when generating SDKs). I'm not sure how the other SDKs are reporting the version number, but again, the python version is at 2.0.0. There is a fair amount added to datamigration's functionality so it may be appropriate to bump it to 2.1.0. Thanks.

Copy link
Contributor

@vchske vchske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the versioning, this looks good.

@lmazuel
Copy link
Member

lmazuel commented Oct 29, 2018

@AutorestCI
Copy link
Contributor Author

Nothing to rebuild, this PR is up to date

@lmazuel lmazuel merged commit 84a7722 into master Nov 5, 2018
@lmazuel lmazuel deleted the restapi_auto_datamigration/resource-manager branch November 5, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants