Skip to content

Handle when no "direct" packages are changed #37599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Handle when no "direct" packages are changed #37599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
715bad3
need to repair analyze
scbedd Sep 26, 2024
a61543d
repair endless analyze and when there are no directly touched packages
scbedd Sep 26, 2024
746bdc9
there we go! missed includeindirect = false
scbedd Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/pipelines/templates/jobs/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ jobs:
parameters:
BuildTargetingString: ${{ parameters.BuildTargetingString }}
PackagePropertiesFolder: $(Build.ArtifactStagingDirectory)/PackageInfo
IncludeIndirect: true
IncludeIndirect: false

- template: /eng/pipelines/templates/steps/build-extended-artifacts.yml
parameters:
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
parameters:
BuildTargetingString: ${{ parameters.BuildTargetingString }}
PackagePropertiesFolder: $(Build.ArtifactStagingDirectory)/PackageInfo
IncludeIndirect: true
IncludeIndirect: false

- template: ../steps/build-extended-artifacts.yml
parameters:
Expand Down
6 changes: 6 additions & 0 deletions eng/pipelines/templates/steps/resolve-package-targeting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ steps:
}

$setting = $packageProperties -join ","

# in case we don't expect any packages, we should set the variable to null, which will match NO packages and cause whatever the check
# is to skip with exit 0 (which is what we want!)
if (-not $setting) {
$setting = "null"
}
}
}

Expand Down
Loading