Skip to content

Updating Rooms to include Collaborator Role. #39788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 5, 2025

Conversation

paolamvhz
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • [X ] The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [X ] I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 19, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-rooms

@allchiang-msft allchiang-msft self-requested a review March 4, 2025 19:39
Copy link
Member

@allchiang-msft allchiang-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments @paolamvhz ! Approved

@paolamvhz paolamvhz merged commit b4a508b into Azure:main Mar 5, 2025
29 checks passed
allenkim0129 pushed a commit to allenkim0129/azure-sdk-for-python that referenced this pull request Mar 11, 2025
* Updating Rooms collaborator Role

* Updating Rooms collaborator Role

* updating sample and tests

* updating sample and tests

* updating sample and tests

* updating tests

* updating tests

* updating api version

* updating change log to the correct version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants