Azure App Configuration Provider Allocation Id #40730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding Telemetry * Telemetry Support * fixing formatting * Update _azureappconfigurationprovider.py * Update _azureappconfigurationproviderasync.py * formatting * changing doc style due to pylint-next * fixing kwargs docs * Formatting * Review comments * Changed label checking. * black format changes * pylint * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py Co-authored-by: Avani Gupta <[email protected]> * added space checks * Update conftest.py * moved telemetry to client wrapper * fixing format * updating after merge * fixing black issue * removing unused imports * AllocationId * Update CODEOWNERS * Update CODEOWNERS * fixing issues * Update _client_manager_base.py * Fixing configuration value empty in calc * fixing pylint * Update _constants.py * review comments * fixing allocation check * format fix --------- Co-authored-by: Avani Gupta <[email protected]>
* Update CHANGELOG.md * Update CHANGELOG.md
* updated calc to sort keys * Update CHANGELOG.md
* updated calc to sort keys * Update CHANGELOG.md * Update _client_manager_base.py
…nfiguration-provider/variants
…tps://github.com/Azure/azure-sdk-for-python into feature/azure-appconfiguration-provider/variants
…nfiguration-provider-exp
…nfiguration-provider-exp
…nfiguration-provider-exp
mrm9084
requested review from
albertofori,
avanigupta and
rossgrambo
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an Allocation ID mechanism for feature flag telemetry while preparing the provider for GA release by updating the version and changelog.
- Adds a new ALLOCATION_ID_KEY constant and logic to compute an Allocation ID based on feature flag configuration.
- Updates the version number to 2.1.0 in the _version.py file and documents the changes in the CHANGELOG.md.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_version.py | Version updated for release. |
| sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_constants.py | Introduces ALLOCATION_ID_KEY for telemetry metadata. |
| sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_client_manager_base.py | Implements Allocation ID generation and attaches it to telemetry if present. |
| sdk/appconfiguration/azure-appconfiguration-provider/CHANGELOG.md | Changelog updated with AllocationId addition and other telemetry changes. |
...tion/azure-appconfiguration-provider/azure/appconfiguration/provider/_client_manager_base.py
Outdated
Show resolved
Hide resolved
rossgrambo
reviewed
Apr 25, 2025
sdk/appconfiguration/azure-appconfiguration-provider/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ross Grambo <[email protected]>
…configuration/provider/_client_manager_base.py Co-authored-by: Copilot <[email protected]>
|
API change check API changes are not detected in this pull request. |
rossgrambo
approved these changes
Apr 28, 2025
bambriz
pushed a commit
to bambriz/azure-sdk-for-python
that referenced
this pull request
May 5, 2025
* Revert "Remove Telemetry from main (Azure#37783)" (Azure#37812) This reverts commit a65dfb2. * Allocation Id (Azure#37840) * Adding Telemetry * Telemetry Support * fixing formatting * Update _azureappconfigurationprovider.py * Update _azureappconfigurationproviderasync.py * formatting * changing doc style due to pylint-next * fixing kwargs docs * Formatting * Review comments * Changed label checking. * black format changes * pylint * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py Co-authored-by: Avani Gupta <[email protected]> * added space checks * Update conftest.py * moved telemetry to client wrapper * fixing format * updating after merge * fixing black issue * removing unused imports * AllocationId * Update CODEOWNERS * Update CODEOWNERS * fixing issues * Update _client_manager_base.py * Fixing configuration value empty in calc * fixing pylint * Update _constants.py * review comments * fixing allocation check * format fix --------- Co-authored-by: Avani Gupta <[email protected]> * Python Provider 2.0.0b2 Changelog update (Azure#37860) * Update CHANGELOG.md * Update CHANGELOG.md * Increment package version after release of azure-appconfiguration-provider (Azure#37877) * Update _client_manager_base.py (Azure#38019) * App Config Allocation Id Update (Azure#38065) * updated calc to sort keys * Update CHANGELOG.md * Allocation id update (Azure#38242) * updated calc to sort keys * Update CHANGELOG.md * Update _client_manager_base.py * Update CHANGELOG.md (Azure#38521) * Increment package version after release of azure-appconfiguration-provider (Azure#38553) * fixing imports * Updating Version and Changelog * Update _client_manager_base.py * Increment package version after release of azure-appconfiguration-provider (Azure#40470) * Updating for release * Update CHANGELOG.md * Update sdk/appconfiguration/azure-appconfiguration-provider/CHANGELOG.md Co-authored-by: Ross Grambo <[email protected]> * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_client_manager_base.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Avani Gupta <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Ross Grambo <[email protected]> Co-authored-by: Copilot <[email protected]>
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
* Revert "Remove Telemetry from main (#37783)" (#37812) This reverts commit a65dfb2. * Allocation Id (#37840) * Adding Telemetry * Telemetry Support * fixing formatting * Update _azureappconfigurationprovider.py * Update _azureappconfigurationproviderasync.py * formatting * changing doc style due to pylint-next * fixing kwargs docs * Formatting * Review comments * Changed label checking. * black format changes * pylint * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py Co-authored-by: Avani Gupta <[email protected]> * added space checks * Update conftest.py * moved telemetry to client wrapper * fixing format * updating after merge * fixing black issue * removing unused imports * AllocationId * Update CODEOWNERS * Update CODEOWNERS * fixing issues * Update _client_manager_base.py * Fixing configuration value empty in calc * fixing pylint * Update _constants.py * review comments * fixing allocation check * format fix --------- Co-authored-by: Avani Gupta <[email protected]> * Python Provider 2.0.0b2 Changelog update (#37860) * Update CHANGELOG.md * Update CHANGELOG.md * Increment package version after release of azure-appconfiguration-provider (#37877) * Update _client_manager_base.py (#38019) * App Config Allocation Id Update (#38065) * updated calc to sort keys * Update CHANGELOG.md * Allocation id update (#38242) * updated calc to sort keys * Update CHANGELOG.md * Update _client_manager_base.py * Update CHANGELOG.md (#38521) * Increment package version after release of azure-appconfiguration-provider (#38553) * fixing imports * Updating Version and Changelog * Update _client_manager_base.py * Increment package version after release of azure-appconfiguration-provider (#40470) * Updating for release * Update CHANGELOG.md * Update sdk/appconfiguration/azure-appconfiguration-provider/CHANGELOG.md Co-authored-by: Ross Grambo <[email protected]> * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_client_manager_base.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Avani Gupta <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Ross Grambo <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge Feature Branch into main.