computer vision quickstart #4255

diberry · 2019-01-28T23:55:57Z

No description provided.

adxsdk6 · 2019-01-28T23:55:59Z

Can one of the admins verify this patch?

adxsdk6 · 2019-01-28T23:55:59Z

Can one of the admins verify this patch?

diberry · 2019-01-28T23:56:57Z

#hold-off Please don't begin to review this yet. It isn't done

codecov-io · 2019-01-29T04:30:40Z

Codecov Report

Merging #4255 into master will decrease coverage by 3.9%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4255      +/-   ##
==========================================
- Coverage   53.38%   49.48%   -3.91%     
==========================================
  Files       10464     6276    -4188     
  Lines      219586   176038   -43548     
==========================================
- Hits       117229    87110   -30119     
+ Misses     102357    88928   -13429

Impacted Files	Coverage Δ
...afactory/azure/mgmt/datafactory/models/__init__.py	`50.67% <0%> (-49.33%)`	⬇️
...ights/azure/applicationinsights/models/__init__.py	`51% <0%> (-49%)`	⬇️
...e/cognitiveservices/vision/face/models/__init__.py	`51.25% <0%> (-48.75%)`	⬇️
...iveservices/search/entitysearch/models/__init__.py	`51.25% <0%> (-48.75%)`	⬇️
azure-eventgrid/azure/eventgrid/models/__init__.py	`51.25% <0%> (-48.75%)`	⬇️
...ration/azure/mgmt/datamigration/models/__init__.py	`51.27% <0%> (-48.73%)`	⬇️
...ure/mgmt/recoveryservicesbackup/models/__init__.py	`51.46% <0%> (-48.54%)`	⬇️
...ce/azure/mgmt/containerinstance/models/__init__.py	`51.8% <0%> (-48.2%)`	⬇️
...tiveservices/search/videosearch/models/__init__.py	`52.08% <0%> (-47.92%)`	⬇️
.../azure/mgmt/compute/v2018_10_01/models/__init__.py	`52.46% <0%> (-47.54%)`	⬇️
... and 4270 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53e2fa...f2927d3. Read the comment docs.

mmacy

This is looking really good! Seeing it this way really makes this SDK seem easy to use, and I'm actually gonna give it a whirl now that I've seen this. 😉

For the examples, I think you can add a leeeetle more description to them. Brevity is certainly good, but if there are any gotchas or tips or simply something that'd be Good To Know for those operations, don't feel so hand-tied that you can't add a little nugget here and there. Then again, if there isn't much more to add, don't do so just 'cause I said add something (since I don't know the SDK or the service!).

azure-cognitiveservices-vision-computervision/README.md

mmacy

This is awesome, Dina. Pretty much exactly what I'd both want and expect to see in a README.

azure-cognitiveservices-vision-computervision/README.md

mmacy

Suuuper close!

azure-cognitiveservices-vision-computervision/README.md

mmacy · 2019-02-06T23:11:51Z

@lmazuel Any idea on why the build is failing in this PR? Dina's integrated the modifications details by you and @johanste, so perhaps there's something else we need?

Cc: @diberry

mmacy · 2019-02-28T17:31:34Z

@lmazuel @scbedd Laurent and Scott, how's this looking now - GTG for merge?

Cc: @diberry

lmazuel · 2019-03-01T17:13:53Z

I didn't tested PyPI with Markdown yet, but looks to me this follows the guideline and should be fine.

lmazuel · 2019-03-01T19:08:55Z

azure-cognitiveservices-vision-computervision/sdk_packaging.toml

@@ -4,3 +4,4 @@ package_pprint_name = "Cognitive Services Computer Vision"
 package_doc_id = "cognitive-services"
 is_stable = false
 is_arm = false
+autoupdate = false


It's actually auto_update (my mistake, sorry)

@diberry Looks like we have a merge conflict and need another edit (per @lmazuel). I can issue a PR into yours, or take all these changes and open a new PR under my account, then shepherd it through the process without needing to bug you again. 😄 Happy do do either--what's your preference?

…ry/azure-sdk-for-python into 0124-python-computervision

mmacy · 2019-03-19T14:52:40Z

@lmazuel I believe Dina had this ready to roll awhile ago, but now we've got merge conflicts again. What's the proper procedure to get this PR merged? Ping you directly when ready?

Cc: @diberry

diberry · 2019-03-19T15:10:36Z

@lmazuel @mmacy If I fix the merge conflicts, can the doc be merged today or is there something else that needs to be changed? Can we merge what is there then change in another PR if there are alterations. The original request is a month and a half old -- so just trying to figure out how to finish this.

mmacy · 2019-03-19T15:19:10Z

just trying to figure out how to finish this.

Me too. I'd love it if @lmazuel or someone on his team could sign up to be on-deck for merging this thing once the conflicts are resolved and you tag them to notify them when it's ready. I think what's happening is that it gets buried and doesn't come up on anyone's radar when it's actually ready to go.

Once we get confirmation from Laurent that (other than the conflicts) it's ready to go, you can resolve the conflicts, then fire off some flares to explicitly notify them that it's ready for merge.

mmacy · 2019-04-02T21:34:47Z

@lmazuel Hey Laurent, what's the best path to take with this PR? It's been ready for merge a couple of different times now, but it's not been merged, and then conflicts creep in and it sits. I'm concerned that if I or Dina fix the conflicts we'll be in the same situation, so would love to know how we can best proceed.

loarabia · 2019-06-28T23:05:35Z

CC: @lmazuel

lmazuel · 2019-06-28T23:59:36Z

@mmacy @loarabia I believe there is a misunderstanding here: I don't own this PR and I'm not the right person to decide what to do with it :). It comes from data-plane discussion on Cognitive Services, and I have no say in the content of this file if it matches the guidelines of @johanste

I would suggest to fix the conflicts, rebase with master. be sure it passes CI (@scbedd can help to be sure CI is actually checking this README against the CI) and merge it :). I could do a final review if you wish in the form, but I let you guys decide the content ;)

Petermarcu · 2020-03-10T18:11:07Z

Do we still need to get this in? If so, it looks like we need to make sure someone that can merge is on point to merge when ready.

scbedd · 2020-03-10T18:25:01Z

I'll take an action item to get the conflicts resolved and the PR merged.

johanste · 2020-03-10T18:54:20Z

Please note that there's been a couple of releases since this PR was opened.

lmazuel · 2020-03-11T00:14:27Z

I'll look at that tomorrow, as repenting our sins on this PR length....

scbedd · 2020-03-11T04:13:10Z

I have resolved the merge conflicts, so @lmazuel it's just a review of the content here.

…rvision

lmazuel · 2020-03-11T20:29:08Z

I updated the Readme with all changes since this PR was open, and executed manually all the samples to be sure they were working correctly.

MERGING!

lmazuel

Checked-out the branch and tried them all, good to go

computer vision quickstart

691464f

diberry requested a review from lmazuel as a code owner January 28, 2019 23:55

save thumbnail to file

0dfafdb

edits

96646f4

mmacy suggested changes Jan 29, 2019

View reviewed changes

mmacy reviewed Jan 29, 2019

View reviewed changes

azure-cognitiveservices-vision-computervision/README.md Outdated Show resolved Hide resolved

mmacy reviewed Jan 30, 2019

View reviewed changes

azure-cognitiveservices-vision-computervision/README.md Outdated Show resolved Hide resolved

diberry added 4 commits January 30, 2019 07:26

edits based on Marsh's feedback

b67018c

edits

0acdadd

edits

bfaa0de

edits based on Anna's feedback

e98d3cf

mmacy suggested changes Jan 30, 2019

View reviewed changes

diberry added 4 commits February 1, 2019 09:44

edits based on feedback - some links fixed - tbd - read of links

e1817c5

links should be fixed

551da34

remove unused links

b8d56a3

fix spelling

7d75a0d

mmacy suggested changes Feb 1, 2019

View reviewed changes

diberry added 2 commits February 5, 2019 12:38

edits based on Marsh's feedback

5396c0d

added pip package reference into install section

57a524a

mmacy reviewed Feb 5, 2019

View reviewed changes

azure-cognitiveservices-vision-computervision/README.md Outdated Show resolved Hide resolved

diberry added 5 commits February 6, 2019 07:19

Larent and Johan's changes

2e27f60

edit package link name

d9ae272

fixing reference for readme.md

28deacf

changes based on azure-template/setup.py

f84e0cb

adding long description back

9c0d301

lmazuel previously approved these changes Mar 1, 2019

View reviewed changes

lmazuel reviewed Mar 1, 2019

View reviewed changes

diberry added 3 commits March 6, 2019 12:16

remove *.rst file - fix merge conflict

7c3269d

autoupdate to auto_update

2936abb

Merge branch '0124-python-computervision' of https://github.com/diber…

f2927d3

…ry/azure-sdk-for-python into 0124-python-computervision

loarabia added the Cognitive Services label Jun 28, 2019

merging master into cognitiveservices vision

f03e0ee

scbedd dismissed lmazuel’s stale review via 370ed8a March 11, 2020 04:10

diberry requested review from mayurid and zikalino as code owners March 11, 2020 04:10

returning mgmt-batch to what it should be

370ed8a

lmazuel added 3 commits March 11, 2020 12:56

Merge remote-tracking branch 'origin/master' into 0124-python-compute…

bffba83

…rvision

First pass fixing just reading the Readme

72115e2

Fix recognize_text sample

2f37c50

lmazuel approved these changes Mar 11, 2020

View reviewed changes

lmazuel merged commit 9063485 into Azure:master Mar 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

computer vision quickstart #4255

computer vision quickstart #4255

diberry commented Jan 28, 2019

adxsdk6 commented Jan 28, 2019

adxsdk6 commented Jan 28, 2019

diberry commented Jan 28, 2019

codecov-io commented Jan 29, 2019 •

edited

Loading

mmacy left a comment

mmacy left a comment

mmacy left a comment

mmacy commented Feb 6, 2019

mmacy commented Feb 28, 2019

lmazuel commented Mar 1, 2019

lmazuel Mar 1, 2019

mmacy Mar 6, 2019

mmacy commented Mar 19, 2019

diberry commented Mar 19, 2019

mmacy commented Mar 19, 2019

mmacy commented Apr 2, 2019

loarabia commented Jun 28, 2019

lmazuel commented Jun 28, 2019

Petermarcu commented Mar 10, 2020

scbedd commented Mar 10, 2020 •

edited

Loading

johanste commented Mar 10, 2020

lmazuel commented Mar 11, 2020

scbedd commented Mar 11, 2020

lmazuel commented Mar 11, 2020

lmazuel left a comment

computer vision quickstart #4255

computer vision quickstart #4255

Conversation

diberry commented Jan 28, 2019

adxsdk6 commented Jan 28, 2019

adxsdk6 commented Jan 28, 2019

diberry commented Jan 28, 2019

codecov-io commented Jan 29, 2019 • edited Loading

Codecov Report

mmacy left a comment

Choose a reason for hiding this comment

mmacy left a comment

Choose a reason for hiding this comment

mmacy left a comment

Choose a reason for hiding this comment

mmacy commented Feb 6, 2019

mmacy commented Feb 28, 2019

lmazuel commented Mar 1, 2019

lmazuel Mar 1, 2019

Choose a reason for hiding this comment

mmacy Mar 6, 2019

Choose a reason for hiding this comment

mmacy commented Mar 19, 2019

diberry commented Mar 19, 2019

mmacy commented Mar 19, 2019

mmacy commented Apr 2, 2019

loarabia commented Jun 28, 2019

lmazuel commented Jun 28, 2019

Petermarcu commented Mar 10, 2020

scbedd commented Mar 10, 2020 • edited Loading

johanste commented Mar 10, 2020

lmazuel commented Mar 11, 2020

scbedd commented Mar 11, 2020

lmazuel commented Mar 11, 2020

lmazuel left a comment

Choose a reason for hiding this comment

codecov-io commented Jan 29, 2019 •

edited

Loading

scbedd commented Mar 10, 2020 •

edited

Loading