Replace Model trait with Format trait (applied to Response instead)

sdk/core/azure_core/src/http/mod.rs

@@ -21,5 +21,9 @@ pub use response::Response;
 
 pub use typespec_client_core::http::response;
 pub use typespec_client_core::http::{
-    new_http_client, AppendToUrlQuery, Context, HttpClient, Method, StatusCode, Url,
+    new_http_client, AppendToUrlQuery, Context, Format, HttpClient, JsonFormat, Method, StatusCode,
+    Url,
 };
+
+#[cfg(feature = "xml")]
+pub use typespec_client_core::http::XmlFormat;

sdk/core/azure_core/src/http/pipeline.rs

@@ -8,7 +8,7 @@ use std::{
     ops::Deref,
     sync::Arc,
 };
-use typespec_client_core::http::{self, policies::Policy};
+use typespec_client_core::http::{self, policies::Policy, Format, JsonFormat};
 
 /// Execution pipeline.
 ///
@@ -34,14 +34,17 @@ use typespec_client_core::http::{self, policies::Policy};
 /// cannot be enforced by code). All policies except Transport policy can assume there is another following policy (so
 /// `self.pipeline[0]` is always valid).
 #[derive(Debug, Clone)]
-pub struct Pipeline(http::Pipeline);
+pub struct Pipeline<F: Format = JsonFormat>(http::Pipeline<F>);
 
-impl Pipeline {
+impl<F: Format> Pipeline<F> {
     /// Creates a new pipeline given the client library crate name and version,
     /// alone with user-specified and client library-specified policies.
     ///
     /// Crates can simply pass `option_env!("CARGO_PKG_NAME")` and `option_env!("CARGO_PKG_VERSION")` for the
     /// `crate_name` and `crate_version` arguments respectively.
+    ///
+    /// In addition, this constructor allows for specifying the response format (e.g. JSON, XML) to be used
+    /// when deserializing the response body.
     pub fn new(
         crate_name: Option<&'static str>,
         crate_version: Option<&'static str>,
@@ -75,8 +78,8 @@ impl Pipeline {
 }
 
 // TODO: Should we instead use the newtype pattern?
-impl Deref for Pipeline {
-    type Target = http::Pipeline;
+impl<F: Format> Deref for Pipeline<F> {
+    type Target = http::Pipeline<F>;
     fn deref(&self) -> &Self::Target {
         &self.0
     }

sdk/storage/azure_storage_blob/src/clients/blob_client.rs

@@ -25,6 +25,7 @@ use azure_core::{
     Bytes, Result,
 };
 use std::sync::Arc;
+use typespec_client_core::http::XmlFormat;
 
 /// A client to interact with a specific Azure storage blob, although that blob may not yet exist.
 pub struct BlobClient {
@@ -114,7 +115,7 @@ impl BlobClient {
     pub async fn get_properties(
         &self,
         options: Option<BlobClientGetPropertiesOptions<'_>>,
-    ) -> Result<Response<BlobClientGetPropertiesResult>> {
+    ) -> Result<Response<BlobClientGetPropertiesResult, XmlFormat>> {
         self.client.get_properties(options).await
     }
 
@@ -126,7 +127,7 @@ impl BlobClient {
     pub async fn set_properties(
         &self,
         options: Option<BlobClientSetPropertiesOptions<'_>>,
-    ) -> Result<Response<()>> {
+    ) -> Result<Response<(), XmlFormat>> {
         self.client.set_properties(options).await
     }
 
@@ -136,7 +137,7 @@ impl BlobClient {
     pub async fn download(
         &self,
         options: Option<BlobClientDownloadOptions<'_>>,
-    ) -> Result<Response<BlobClientDownloadResult>> {
+    ) -> Result<Response<BlobClientDownloadResult, XmlFormat>> {
         self.client.download(options).await
     }
 
@@ -155,7 +156,7 @@ impl BlobClient {
         overwrite: bool,
         content_length: u64,
         options: Option<BlockBlobClientUploadOptions<'_>>,
-    ) -> Result<Response<BlockBlobClientUploadResult>> {
+    ) -> Result<Response<BlockBlobClientUploadResult, XmlFormat>> {
         let mut options = options.unwrap_or_default();
 
         if !overwrite {
@@ -179,7 +180,7 @@ impl BlobClient {
     pub async fn set_metadata(
         &self,
         options: Option<BlobClientSetMetadataOptions<'_>>,
-    ) -> Result<Response<()>> {
+    ) -> Result<Response<(), XmlFormat>> {
         self.client.set_metadata(options).await
     }
 
@@ -191,7 +192,7 @@ impl BlobClient {
     pub async fn delete(
         &self,
         options: Option<BlobClientDeleteOptions<'_>>,
-    ) -> Result<Response<()>> {
+    ) -> Result<Response<(), XmlFormat>> {
         self.client.delete(options).await
     }
 
@@ -206,7 +207,7 @@ impl BlobClient {
         &self,
         tier: AccessTier,
         options: Option<BlobClientSetTierOptions<'_>>,
-    ) -> Result<Response<()>> {
+    ) -> Result<Response<(), XmlFormat>> {
         self.client.set_tier(tier, options).await
     }
 }

sdk/storage/azure_storage_blob/src/clients/blob_container_client.rs

@@ -17,6 +17,7 @@ use azure_core::{
     Result,
 };
 use std::sync::Arc;
+use typespec_client_core::http::XmlFormat;
 
 /// A client to interact with a specified Azure storage container.
 pub struct BlobContainerClient {
@@ -99,7 +100,7 @@ impl BlobContainerClient {
     pub async fn create_container(
         &self,
         options: Option<BlobContainerClientCreateOptions<'_>>,
-    ) -> Result<Response<()>> {
+    ) -> Result<Response<(), XmlFormat>> {
         self.client.create(options).await
     }
 
@@ -113,7 +114,7 @@ impl BlobContainerClient {
     pub async fn set_metadata(
         &self,
         options: Option<BlobContainerClientSetMetadataOptions<'_>>,
-    ) -> Result<Response<()>> {
+    ) -> Result<Response<(), XmlFormat>> {
         self.client.set_metadata(options).await
     }
 
@@ -125,7 +126,7 @@ impl BlobContainerClient {
     pub async fn delete_container(
         &self,
         options: Option<BlobContainerClientDeleteOptions<'_>>,
-    ) -> Result<Response<()>> {
+    ) -> Result<Response<(), XmlFormat>> {
         self.client.delete(options).await
     }
 
@@ -138,7 +139,7 @@ impl BlobContainerClient {
     pub async fn get_properties(
         &self,
         options: Option<BlobContainerClientGetPropertiesOptions<'_>>,
-    ) -> Result<Response<BlobContainerClientGetPropertiesResult>> {
+    ) -> Result<Response<BlobContainerClientGetPropertiesResult, XmlFormat>> {
         self.client.get_properties(options).await
     }
 }

sdk/storage/azure_storage_blob/src/clients/block_blob_client.rs

@@ -105,7 +105,7 @@ impl BlockBlobClient {
         &self,
         blocks: RequestContent<BlockLookupList>,
         options: Option<BlockBlobClientCommitBlockListOptions<'_>>,
-    ) -> Result<Response<BlockBlobClientCommitBlockListResult>> {
+    ) -> Result<Response<BlockBlobClientCommitBlockListResult, XmlFormat>> {
         self.client.commit_block_list(blocks, options).await
     }
 
@@ -124,7 +124,7 @@ impl BlockBlobClient {
         content_length: u64,
         body: RequestContent<Bytes>,
         options: Option<BlockBlobClientStageBlockOptions<'_>>,
-    ) -> Result<Response<BlockBlobClientStageBlockResult>> {
+    ) -> Result<Response<BlockBlobClientStageBlockResult, XmlFormat>> {
         self.client
             .stage_block(block_id, content_length, body, options)
             .await