-
Notifications
You must be signed in to change notification settings - Fork 246
Stored Procedure support for new Execute operation - REST and GraphQL #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 81 commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
bc8e86c
prelim changes.
seantleonard 79ab48c
Updating operation/action handling in validation and ensuring SP's ar…
seantleonard 27fd899
Proper operation resolution and execute field naming for SP's
seantleonard e022fed
Updates for adding Operation configuraiton for StoredProcedure GraphQ…
seantleonard 309d0de
updated processing.
seantleonard 8a92973
Updated Authorization and REST processing of EXECUTE for SPs.
seantleonard c3ff6ea
Revisions and helper methods, and method comments added.
seantleonard fae92a5
Add tests.
seantleonard 855cfd5
Added more comments.
seantleonard 7b29920
Added more GraphQL tests and added more comments referencing GraphQL …
seantleonard 746ca9d
Fixed spacing and usings.
seantleonard 0ee6ecb
update reference configuration for stored procedures.
seantleonard 832eb22
Merge branch 'main' into dev/seleonar/operationSpExecute
seantleonard 9b2fd3e
remove whitespace. and fix broken query generation logic.
seantleonard c87cc72
Merge branch 'dev/seleonar/operationSpExecute' of https://github.com/…
seantleonard 2e2a7f2
Merge branch 'main' into dev/seleonar/operationSpExecute
seantleonard adfa158
updated tests.
seantleonard fd4ec5a
Merge branch 'dev/seleonar/operationSpExecute' of https://github.com/…
seantleonard 5848c75
Merge branch 'main' into dev/seleonar/operationSpExecute
seantleonard 83b497e
Fix permissions operations to be execute for stored procedure entitie…
seantleonard 38350f3
Updated CLI handling of execute operation.
seantleonard 6df9443
Fix CLI tests to be compatible with Execute operation for stored proc…
seantleonard ae4f486
fix permissions on mssqlcommands script.
seantleonard 7dfc6d6
Updated tests and Configuration handling.
seantleonard b28d631
Addressing PR feedback.
seantleonard aedfa97
fix formatting
seantleonard 3f84ad9
fixed test.
seantleonard a3e3a00
CLI - Execute action for stored procedures (#1129)
severussundar bf2dd7d
updates for compatibility
seantleonard 6f07e07
Addressing PR feedback.
seantleonard 28c5a44
refining logic.
seantleonard cbc5a84
added code comments.
seantleonard 8aa7e2c
Merge branch 'main' into dev/seleonar/operationSpExecute
seantleonard cfb144f
Updated spacing.
seantleonard 5b08044
Merge branch 'main' into dev/seleonar/operationSpExecute
seantleonard 6459f79
Execute Action - Update Command (#1139)
severussundar 7b9acf3
updated from Feedback
seantleonard 79e5f9a
Remove stored procedure entities from sql reference json schema since…
seantleonard f7d8595
REST json key `method` to `methods`
seantleonard ba1a05c
Clean up nits and add comments to methods without descriptions.
seantleonard d9d929c
added comments
seantleonard f351525
Merge branch 'main' into dev/seleonar/operationSpExecute
Aniruddh25 f727551
added Sales table back to reference.
seantleonard 6b0d9e3
Merge branch 'dev/seleonar/operationSpExecute' of https://github.com/…
seantleonard 4aaf27d
remove changed file.
seantleonard 0df031f
more concise switch + code comments.
seantleonard 79bd673
more code comments, renames for clarification and removal of empty li…
seantleonard 8c3da8a
remove using.
seantleonard 7704c00
merge conflict resolve
seantleonard ad6dcbb
Merge branch 'main' into dev/seleonar/operationSpExecute
seantleonard 07b291a
Merge branch 'main' into dev/seleonar/operationSpExecute
severussundar 7cf3cad
Merge branch 'dev/seleonar/operationSpExecute' of https://github.com/…
severussundar a001740
addressing nits
severussundar 7ce7c36
Merge branch 'main' into dev/seleonar/operationSpExecute
severussundar 08bcdb5
fixing deserialization of graphql operation, removing ignore in query…
severussundar 5cbe288
fixing deserialization test
severussundar 7d104ec
fix formatting
severussundar 3baea85
updating rest methods for GetBook, GetBooks
severussundar 916a56d
Including REST find tests for SPs
severussundar 78a05b5
adding rest methods to find api tests
severussundar 0d2f964
enabling source type conversion
severussundar d7da119
fixing formatting
severussundar a25f767
updating logic for update rest,grapql options
severussundar 5060872
remove rest command from cosmos db commands
severussundar befcf24
fix return type from 403 to 405 to match HTTP spec and fix type casting.
seantleonard f8cf3a2
resolve nits in PR feedback.
seantleonard 490cc77
Address feedback from PR
seantleonard b568a99
address feedback for renaming GetGraphQLType() to GetGraphQLEnabledOr…
seantleonard ecae95c
CLI resolve operations for permission based on SourceType, special ha…
seantleonard c5f1a84
fix empty code
seantleonard 3cf33c7
additional check for stored proc
seantleonard c435fba
Fix flip flopped valid ops
seantleonard b88905a
Update return types and remove unnecessary method.
seantleonard 9f2b277
update valid RestMethod calculation.
seantleonard 22d77d2
Additional Stored Procedure Check.
seantleonard 224624b
Remove dupe code and address feedback. removed unneeded logging.
seantleonard 6dd1ebd
Merge branch 'main' into dev/seleonar/operationSpExecute
seantleonard c09237b
nit: remove ending tabs from line 243:249
seantleonard d01d685
Extra line
seantleonard b625204
update check.
seantleonard 00e1d81
address comment.
seantleonard 63dfc16
adding method summary, modifying a check
severussundar 790b280
Merge branch 'dev/seleonar/operationSpExecute' of https://github.com/…
severussundar d5375f7
Merge branch 'main' into dev/seleonar/operationSpExecute
severussundar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
init --config "dab-config.CosmosDb_NoSql.json" --database-type "cosmosdb_nosql" --connection-string "AccountEndpoint=https://localhost:8081/;AccountKey=C2y6yDjf5/R+ob0N8A7Cgv30VRDJIWEHLM+4QDU5DE2nQ9nDuVTqobD4b8mGGyPMbIZnqyMsEcaGQy67XIw/Jw==" --cosmosdb_nosql-database "graphqldb" --cosmosdb_nosql-container "planet" --graphql-schema "schema.gql" --host-mode Development --cors-origin "http://localhost:5000" | ||
add Planet --config "dab-config.CosmosDb_NoSql.json" --source "graphqldb.planet" --permissions "anonymous:create,read,update,delete" --rest false --graphql "Planet:Planets" | ||
add Planet --config "dab-config.CosmosDb_NoSql.json" --source "graphqldb.planet" --permissions "anonymous:create,read,update,delete" --graphql "Planet:Planets" | ||
update Planet --config "dab-config.CosmosDb_NoSql.json" --permissions "authenticated:create,read,update,delete" | ||
add Character --config "dab-config.CosmosDb_NoSql.json" --source "graphqldb.character" --permissions "authenticated:create,read,update,delete" --rest false --graphql "Character:Characters" | ||
add StarAlias --config "dab-config.CosmosDb_NoSql.json" --source "graphqldb.star" --permissions "anonymous:create,read,update,delete" --rest false --graphql "Star:Stars" | ||
add Character --config "dab-config.CosmosDb_NoSql.json" --source "graphqldb.character" --permissions "authenticated:create,read,update,delete" --graphql "Character:Characters" | ||
add StarAlias --config "dab-config.CosmosDb_NoSql.json" --source "graphqldb.star" --permissions "anonymous:create,read,update,delete" --graphql "Star:Stars" | ||
update StarAlias --config "dab-config.CosmosDb_NoSql.json" --source "graphqldb.star" --permissions "authenticated:create,read,update,delete" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.