Skip to content

Adding tests for pg nested filtering #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 2, 2023
Merged

Conversation

gledis69
Copy link
Contributor

@gledis69 gledis69 commented Jan 31, 2023

Why make this change?

  • This is just to validate that the nested filtering implementation works for pg. @Aniruddh25 implemented the actual feature.

What is this change?

  • Adding skipped nested filtering tests for pg

How was this tested?

  • Integration Tests

Sample Request(s)

N/A

Copy link
Contributor

@abhishekkumams abhishekkumams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it include configGenerator.sh file if there is no change?

Copy link
Contributor

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition of tests to base class to avoid code duplication.

@Aniruddh25 Aniruddh25 linked an issue Jan 31, 2023 that may be closed by this pull request
@gledis69
Copy link
Contributor Author

gledis69 commented Feb 1, 2023

Why does it include configGenerator.sh file if there is no change?

I ran chmod +x ConfigGenerators/configGenerator.sh
since I couldn't execute the script like: ./ConfigGenerators/configGenerator.sh postgresql

This changes the file mode from 644 (rw-r--r--) to 755 (wrxr-xr-x), so the file contents didn't change, but the file metadata.

@gledis69 gledis69 force-pushed the pg-gql-nested-filtering branch from eedf161 to c5c54ec Compare February 1, 2023 10:49
@gledis69 gledis69 force-pushed the pg-gql-nested-filtering branch from c5c54ec to 6560936 Compare February 1, 2023 11:12
Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

@Aniruddh25 Aniruddh25 merged commit 3ada529 into main Feb 2, 2023
@Aniruddh25 Aniruddh25 deleted the pg-gql-nested-filtering branch February 2, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested Filtering for PgSQL
4 participants