-
Notifications
You must be signed in to change notification settings - Fork 246
Adding tests for pg nested filtering #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it include configGenerator.sh file if there is no change?
src/Service.Tests/SqlTests/GraphQLFilterTests/PostgreSqlGQLFilterTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addition of tests to base class to avoid code duplication.
I ran This changes the file mode from 644 (rw-r--r--) to 755 (wrxr-xr-x), so the file contents didn't change, but the file metadata. |
eedf161
to
c5c54ec
Compare
c5c54ec
to
6560936
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
src/Service.Tests/SqlTests/GraphQLFilterTests/GraphQLFilterTestBase.cs
Outdated
Show resolved
Hide resolved
src/Service.Tests/SqlTests/GraphQLFilterTests/PostgreSqlGQLFilterTests.cs
Outdated
Show resolved
Hide resolved
…tBase.cs Co-authored-by: Sean Leonard <[email protected]>
…terTests.cs Co-authored-by: Sean Leonard <[email protected]>
Why make this change?
What is this change?
How was this tested?
Sample Request(s)
N/A