-
Notifications
You must be signed in to change notification settings - Fork 247
Renaming to prepare for proc/function support for Pg #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayush3797
reviewed
Feb 3, 2023
ayush3797
reviewed
Feb 3, 2023
ayush3797
reviewed
Feb 3, 2023
ayush3797
reviewed
Feb 3, 2023
I think once all the conflicts are resolved, it would be easier to review. |
245d896
to
94efe5a
Compare
Aniruddh25
previously approved these changes
Feb 3, 2023
d08890a
to
2a60577
Compare
4ed97b7
to
308be20
Compare
Need more time to review, given the new function
source type.
There have been many changes since this was opened. Closing for now and you can re-open with latest changes and conflicts resolve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Postgres stored procedures and function are very similar in the way they are defined. The differences as far as our application are concerned are:
CALL <procedure_name>
, while functions are called asSELECT * FROM <function_name>
orSELECT <function_name>
.Due to these small differences procedures and functions for pg can be handled the same for the most part in our engine so this PR generalizes the nomenclature of any
StoredProcedure
related structure toDatabaseExecutable
to imply both stored procedures and functions. I imagine this will be useful forMsSql
andMySql
as well when they add function support.This PR is a prerequisite for a subsequent PR which will add procedure/function support for PG, but I figured this can be reviewed and merged separately since reviewing the proc/func support PR would become too hard due to all the refactoring.
What is this change?
StoredProcedure
to smth more genericDatabaseExecutable
.How was this tested?
Sample Request(s)
N/A