-
Notifications
You must be signed in to change notification settings - Fork 362
[Bug] Managed Identity should respect source when retrying request, IMDS has more codes should retry #4998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Need to work with MSI team to finalize on this one.
Retry Strategy (Exponential Backoff)
Notes:
|
@gladjohn can you order that table in ascending order for http status code? Additionally, what is the last item "timeout"? 408 (request timeout) or 504 (gateway timeout)? Can we be more specific for that item? Additionally, can we keep all exponential backoffs to the same values? Why does 429 need to start at 2 seconds instead of 1? |
This is not the final @Robbie-Microsoft, this is just a starting point and needs review by MSI team. |
The same retry policy was previously being used for all Managed Identity sources and requests. The retry policy will now be based on the Managed Identity source, and therefore will be per-request. Future Work: Create an IMDS retry policy to address [this bug](AzureAD/microsoft-authentication-library-for-dotnet#4998).
Library version used
4.66.0
.NET version
.NET 9
Scenario
ManagedIdentityClient - managed identity
Is this a new or an existing app?
This is a new app or experiment
Issue description and reproduction steps
For MI The application only retries on
404 or 408 or 429 or 500 or 503 or 504 these codes
but for IMDS only you need to try on more codes. More information here
https://learn.microsoft.com/en-gb/entra/identity/managed-identities-azure-resources/how-to-use-vm-token#error-handling
Relevant code snippets
No response
Expected behavior
No response
Identity provider
Other
Regression
No response
Solution and workarounds
No response
The text was updated successfully, but these errors were encountered: