-
Notifications
You must be signed in to change notification settings - Fork 366
ADFS Compatibility with MSAL #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tnet#1293) in MSAL v2 (pre-ADAL split) to MSAL v3 for further work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
It seems like you will need to merge with dev3x (a branch in rapid changes) |
@rossbuggins |
# Conflicts: # src/Microsoft.Identity.Client/AppConfig/AbstractApplicationBuilder.cs # src/Microsoft.Identity.Client/Cache/Items/MsalRefreshTokenCacheItem.cs # src/Microsoft.Identity.Client/Instance/AdfsOpenIdConfigurationEndpointManager.cs # src/Microsoft.Identity.Client/Instance/Authority.cs # src/Microsoft.Identity.Client/Instance/AuthorityEndpointResolutionManager.cs # src/Microsoft.Identity.Client/MsalErrorMessage.cs # src/Microsoft.Identity.Client/TokenCache.cs # tests/Microsoft.Identity.Test.Common/Core/Mocks/MockHelpers.cs # tests/Microsoft.Identity.Test.Common/MsalTestConstants.cs # tests/Microsoft.Identity.Test.Core.UIAutomation/CoreUiTestConstants.cs # tests/Microsoft.Identity.Test.Integration.net45/HeadlessTests/UsernamePasswordIntegrationTests.cs # tests/Microsoft.Identity.Test.Integration.net45/Infrastructure/SeleniumExtensions.cs # tests/Microsoft.Identity.Test.Integration.net45/SeleniumTests/DeviceCodeFlowIntegrationTest.cs # tests/Microsoft.Identity.Test.Integration.net45/SeleniumTests/InteractiveFlowTests.cs # tests/Microsoft.Identity.Test.LabInfrastructure/LabApiConstants.cs # tests/Microsoft.Identity.Test.LabInfrastructure/LabServiceApi.cs # tests/Microsoft.Identity.Test.LabInfrastructure/UserQueryParameters.cs # tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/PublicClientApplicationTests.cs # tests/Microsoft.Identity.Test.Unit.net45/RequestsTests/DeviceCodeRequestTests.cs # tests/devapps/DesktopTestApp/MainForm.cs
Removing client secret being read from file for tests.
src/Microsoft.Identity.Client/Internal/Requests/AuthenticationRequestParameters.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Client/Internal/Requests/AuthenticationRequestParameters.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make code robust to null as well as ""
Fixing broken integration tests.
# Conflicts: # tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/PublicClientApplicationTests.cs
Refactoring
No description provided.