Skip to content

ADFS Compatibility with MSAL #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
May 17, 2019
Merged

ADFS Compatibility with MSAL #834

merged 35 commits into from
May 17, 2019

Conversation

reed1995
Copy link
Contributor

No description provided.

Copy link
Contributor

@henrik-me henrik-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@henrik-me
Copy link
Contributor

It seems like you will need to merge with dev3x (a branch in rapid changes)

@jmprieur
Copy link
Contributor

@rossbuggins
actually the Windows Server patch will be in the May release.
Therefore, ADFS 2019 is not yet supported

@rossbuggins
Copy link

rossbuggins commented Apr 24, 2019 via email

trwalke added 2 commits May 9, 2019 18:27
# Conflicts:
#	src/Microsoft.Identity.Client/AppConfig/AbstractApplicationBuilder.cs
#	src/Microsoft.Identity.Client/Cache/Items/MsalRefreshTokenCacheItem.cs
#	src/Microsoft.Identity.Client/Instance/AdfsOpenIdConfigurationEndpointManager.cs
#	src/Microsoft.Identity.Client/Instance/Authority.cs
#	src/Microsoft.Identity.Client/Instance/AuthorityEndpointResolutionManager.cs
#	src/Microsoft.Identity.Client/MsalErrorMessage.cs
#	src/Microsoft.Identity.Client/TokenCache.cs
#	tests/Microsoft.Identity.Test.Common/Core/Mocks/MockHelpers.cs
#	tests/Microsoft.Identity.Test.Common/MsalTestConstants.cs
#	tests/Microsoft.Identity.Test.Core.UIAutomation/CoreUiTestConstants.cs
#	tests/Microsoft.Identity.Test.Integration.net45/HeadlessTests/UsernamePasswordIntegrationTests.cs
#	tests/Microsoft.Identity.Test.Integration.net45/Infrastructure/SeleniumExtensions.cs
#	tests/Microsoft.Identity.Test.Integration.net45/SeleniumTests/DeviceCodeFlowIntegrationTest.cs
#	tests/Microsoft.Identity.Test.Integration.net45/SeleniumTests/InteractiveFlowTests.cs
#	tests/Microsoft.Identity.Test.LabInfrastructure/LabApiConstants.cs
#	tests/Microsoft.Identity.Test.LabInfrastructure/LabServiceApi.cs
#	tests/Microsoft.Identity.Test.LabInfrastructure/UserQueryParameters.cs
#	tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/PublicClientApplicationTests.cs
#	tests/Microsoft.Identity.Test.Unit.net45/RequestsTests/DeviceCodeRequestTests.cs
#	tests/devapps/DesktopTestApp/MainForm.cs
Removing client secret being read from file for tests.
Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make code robust to null as well as ""

Fixing broken integration tests.
trwalke added 4 commits May 16, 2019 11:23
# Conflicts:
#	tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/PublicClientApplicationTests.cs
@trwalke trwalke merged commit 4562153 into master May 17, 2019
@trwalke trwalke deleted the rewilli/adfs branch May 17, 2019 00:00
@jmprieur jmprieur changed the title ADFS Compatability with MSAL ADFS Compatibility with MSAL Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants