added and updated unit test for bug fix

Author: lalimasharda

lib/msal-angular/src/msal.broadcast.service.spec.ts

@@ -443,4 +443,32 @@ describe("MsalBroadcastService", () => {
       InteractionType.Redirect
     );
   });
+
+  it("automatically sets inProgress to None when handleRedirectPromise returns without emitting HANDLE_REDIRECT_END", (done) => {
+    const expectedInProgress = [
+      InteractionStatus.Startup,
+      InteractionStatus.HandleRedirect,
+      InteractionStatus.None,
+    ];
+    let index = 0;
+
+    subscription = broadcastService.inProgress$.subscribe((result) => {
+      expect(result).toEqual(expectedInProgress[index]);
+      if (index === expectedInProgress.length - 1) {
+        done();
+      } else if (
+        expectedInProgress[index] === InteractionStatus.HandleRedirect
+      ) {
+        index++;
+        broadcastService.resetInProgressEvent();
+      } else {
+        index++;
+      }
+    });
+
+    eventHandler.emitEvent(
+      EventType.HANDLE_REDIRECT_START,
+      InteractionType.Redirect
+    );
+  });
 });

lib/msal-angular/src/msal.service.spec.ts

@@ -2,12 +2,14 @@ import { TestBed } from "@angular/core/testing";
 import {
   AuthenticationResult,
   AuthError,
+  InteractionStatus,
   InteractionType,
   Logger,
   PublicClientApplication,
   SilentRequest,
 } from "@azure/msal-browser";
 import { MsalModule, MsalBroadcastService, MsalService } from "./public-api";
+import { takeLast } from "rxjs/operators";
 
 let authService: MsalService;
 let broadcastService: MsalBroadcastService;
@@ -351,11 +353,14 @@ describe("MsalService", () => {
   });
 
   describe("handleRedirectObservable", () => {
-    it("success", (done) => {
+    it("success and resets inProgress event to none", (done) => {
       const sampleAccessToken = {
         accessToken: "123abc",
       };
 
+      //@ts-ignore
+      broadcastService._inProgress.next(InteractionStatus.Startup);
+
       spyOn(PublicClientApplication.prototype, "initialize").and.returnValue(
         Promise.resolve()
       );
@@ -380,13 +385,19 @@ describe("MsalService", () => {
           expect(
             PublicClientApplication.prototype.handleRedirectPromise
           ).toHaveBeenCalled();
+          broadcastService.inProgress$.subscribe((result) => {
+            expect(result).toBe(InteractionStatus.None);
+          });
           done();
         });
     });
 
-    it("failure", (done) => {
+    it("failure and also resets inProgress event to none", (done) => {
       const sampleError = new AuthError("123", "message");
 
+      //@ts-ignore
+      broadcastService._inProgress.next(InteractionStatus.Startup);
+
       spyOn(PublicClientApplication.prototype, "initialize").and.returnValue(
         Promise.resolve()
       );
@@ -409,6 +420,10 @@ describe("MsalService", () => {
           expect(
             PublicClientApplication.prototype.handleRedirectPromise
           ).toHaveBeenCalled();
+          broadcastService.inProgress$.pipe(takeLast(1)).subscribe((result) => {
+            console.log("failure result", result);
+            expect(result).toBe(InteractionStatus.None);
+          });
           done();
         },
       });