-
Notifications
You must be signed in to change notification settings - Fork 2.7k
ADFS Support? #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Agreed - it would be nice to move to MSAL from ADAL - with ADFS support being the only missing feature for me. |
I second this idea. |
This is fixed in ADFS 2019 and out in the latest insider preview builds. Please do check this out. |
Doesn't work (yet) with ADFS 2019 either even if cors is supported, msal says: "ERROR Error: InvalidAuthorityType" when providing an adfs url instead of aad b2b. Just use ADAL.js for now with ADFS. |
Works like a charm using oidc-client.js with ADFS 2019 with the dropped "resource" requirement and CORS support. |
@ajtowf - do you have a working sample? I'm beating my head against the wall and can't find any examples out there that work in .net core 2.x for using openid against ADFS |
@BatmanAMA @Only1MrAnderson We are testing our latest MSAL JS against this and will update the documentation on ADFS supportability based on the same. Please expect this to be after our current release though. |
@negoe can you please follow up on the ADFS support for MSALs? We do know that we do not support the endpoint directly, Clear documentation will help folks who come to this route. |
@sameerag this is something that would be really useful, teams report that all is working with our .net clients, just the js that its a problem with still. |
@DarylThayil well, its the end of September, whats the word on MSAL for ADFS??? |
@LastTribunal I have done some digging on this and looks like there is more dev work needed to ensure ADFS 2019 is working in MSAL JS. Our initial assumption was that it is more of guidance issue than dev work, which is not true. Most of this work is was heavily contributed by ADFS team on other MSALs and I have started getting together the details to have this supported in MSAL JS. Unfortunately this may not be finished in September, but I will keep updating the progress here. |
@sameerag thanks for the update. I really hope I can get my hands on it soon, i have a hybrid app that works both with Azure AD and ADFS, using ADAL for angular. There are many issues that are making my app almost unusable.. |
@sameerag, I dont get it. If msal with adfs is not supported, what is the purpose of testing for this error? Can you clarify?? |
Yes. I meant msal with ADFS 2019 should work by default and the above bug is blocking that. Can you test now and let me know? Older ADFS (I think <2016) does not work since it isn't federated the way ADFS 2019 is. |
@sameerag do you have a demo msal angular app that i can test against ADFS? |
Just note, from what I understand, the js library is still not supported for adfs, only the .net library
|
@LastTribunal Can you please try this using
|
@sameerag you guys need to come up with an MSAL Angular implementation and demo app that showcases interfacing with both AAD and ADFS ASAP No one cares about MSAL otherwise... what problem does it solve as of right now that ADAL doesnt? The only sick patient is ADALJS/ADALAngular with near fatal symptoms when interfacing with ADFS. I hope the powers at MS are reading this. |
@LastTribunal We are working on Angular release already, please check the project board angular for the progress. We are also working on samples improvements the remaining part of the year. We will follow up with an ADFS 2019 sample once Angular is available.
The request to try Please note that ADFS on prem is not supported and we do not have line of sight on when that would be supported from microsoft client libraries. |
Hello: I've seen that the version 1.2.0 support adfs, but only url microsoft? ¿Is possible use a url adfs private and use Msal? I try do this but I've a error why the library try to redirect a url that it not the mine |
Hi @marisaoliva We would need some time to address this as this would need some significant changes in our |
Hi @sameerag, Just wondering if there is any update for MSAL and on-premise ADFS? We have a React application that would need ADFS access tokens and we got that working using react-adal, however, we're switching to MSAL as ADAL is not supported anymore. Thanks! |
I'd also like to pile on this one. Considering that MSAL.NET supports direct connections to on-prem AD FS 2019+ (with some minor tweaking of generated JWTs, it turns out) I had more or less assumed that MSAL.js would also have similar support, until reading this issue. My colleagues and I would be very keen to see this becoming a reality so that we have similar approaches available for SPAs. |
I've been waiting for support from this so called MSAL team, all I got was empty promises and excuses. Wasted my time |
Update: We expect to add support for ADFS 2019 in 1.4.0. Follow the above pull request for more. Sorry this took so long, appreciate the patience! |
Any plan to add ADFS support as the.net library seems to be working on it.?
AzureAD/microsoft-authentication-library-for-dotnet#143
The text was updated successfully, but these errors were encountered: