Skip to content

ADFS Support? #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Only1MrAnderson opened this issue Jul 21, 2017 · 29 comments · Fixed by #1668 or #2158
Closed

ADFS Support? #99

Only1MrAnderson opened this issue Jul 21, 2017 · 29 comments · Fixed by #1668 or #2158
Assignees
Labels
adfs Related to ADFS feature Feature requests.

Comments

@Only1MrAnderson
Copy link

Any plan to add ADFS support as the.net library seems to be working on it.?

AzureAD/microsoft-authentication-library-for-dotnet#143

@jmprieur jmprieur added question Customer is asking for a clarification, use case or information. enhancement Enhancement to an existing feature or behavior. labels Sep 3, 2017
@mitch-b
Copy link

mitch-b commented Oct 20, 2017

Agreed - it would be nice to move to MSAL from ADAL - with ADFS support being the only missing feature for me.

@glatzert
Copy link

I second this idea.
Unfortunately, ADFS 2016 cannot support JavaScript at this time, because they lack CORS-Features - therefore you cannot read config data or key-material from client-based js.
It would be nice, if the MSAL Team would engage the ADFS-Team with that Problem.

@samueldeva
Copy link

This is fixed in ADFS 2019 and out in the latest insider preview builds. Please do check this out.

@ajtowf
Copy link

ajtowf commented Oct 1, 2018

Doesn't work (yet) with ADFS 2019 either even if cors is supported, msal says: "ERROR Error: InvalidAuthorityType" when providing an adfs url instead of aad b2b. Just use ADAL.js for now with ADFS.

@ajtowf
Copy link

ajtowf commented Oct 1, 2018

Works like a charm using oidc-client.js with ADFS 2019 with the dropped "resource" requirement and CORS support.

@BatmanAMA
Copy link

@ajtowf - do you have a working sample? I'm beating my head against the wall and can't find any examples out there that work in .net core 2.x for using openid against ADFS

@navyasric navyasric removed the question Customer is asking for a clarification, use case or information. label Feb 7, 2019
@navyasric navyasric added core and removed core labels Apr 10, 2019
@sameerag sameerag self-assigned this May 1, 2019
@sameerag sameerag added this to the 1.1.0 milestone May 1, 2019
@sameerag
Copy link
Member

sameerag commented May 1, 2019

@BatmanAMA @Only1MrAnderson We are testing our latest MSAL JS against this and will update the documentation on ADFS supportability based on the same. Please expect this to be after our current release though.

@sameerag sameerag added the documentation Related to documentation. label May 2, 2019
@negoe negoe self-assigned this Jun 24, 2019
@sameerag
Copy link
Member

@negoe can you please follow up on the ADFS support for MSALs? We do know that we do not support the endpoint directly, Clear documentation will help folks who come to this route.

@sameerag sameerag removed their assignment Jun 24, 2019
@sameerag sameerag added the question Customer is asking for a clarification, use case or information. label Jun 26, 2019
@rossbuggins
Copy link

@sameerag this is something that would be really useful, teams report that all is working with our .net clients, just the js that its a problem with still.

@DarylThayil DarylThayil modified the milestones: 1.1.0, 1.2.0 Jul 25, 2019
@LastTribunal
Copy link

@DarylThayil well, its the end of September, whats the word on MSAL for ADFS???
I really would like to ditch my ADAL JS,, which should be sent back to hell where it came from

@sameerag sameerag self-assigned this Sep 27, 2019
@sameerag
Copy link
Member

@LastTribunal I have done some digging on this and looks like there is more dev work needed to ensure ADFS 2019 is working in MSAL JS. Our initial assumption was that it is more of guidance issue than dev work, which is not true. Most of this work is was heavily contributed by ADFS team on other MSALs and I have started getting together the details to have this supported in MSAL JS.

Unfortunately this may not be finished in September, but I will keep updating the progress here.

@LastTribunal
Copy link

@sameerag thanks for the update. I really hope I can get my hands on it soon, i have a hybrid app that works both with Azure AD and ADFS, using ADAL for angular. There are many issues that are making my app almost unusable..

@sameerag sameerag removed this from the September 2019 milestone Oct 2, 2019
@sameerag sameerag removed documentation Related to documentation. enhancement Enhancement to an existing feature or behavior. labels Nov 20, 2019
@LastTribunal
Copy link

@sameerag, I dont get it. If msal with adfs is not supported, what is the purpose of testing for this error?
Are you saying that msal should work with adfs 2019 by default?

Can you clarify??

@sameerag
Copy link
Member

sameerag commented Nov 26, 2019

Yes. I meant msal with ADFS 2019 should work by default and the above bug is blocking that. Can you test now and let me know? Older ADFS (I think <2016) does not work since it isn't federated the way ADFS 2019 is.

@LastTribunal
Copy link

LastTribunal commented Nov 26, 2019

@sameerag do you have a demo msal angular app that i can test against ADFS?

@rossbuggins
Copy link

rossbuggins commented Nov 27, 2019 via email

@sameerag
Copy link
Member

sameerag commented Dec 4, 2019

@LastTribunal Can you please try this using msal-core sample substituting the authority with an ADFS 2019 one? Currently we are working on upgrading angular to msal-core and currently do not have an available sample.

msal latest beta version in npm is the recommended version.

@jmckennon jmckennon added the Issue Triage The engineering team has looked into the issue, understood the issue and classified the issue. label Dec 4, 2019
@LastTribunal
Copy link

@sameerag you guys need to come up with an MSAL Angular implementation and demo app that showcases interfacing with both AAD and ADFS ASAP No one cares about MSAL otherwise... what problem does it solve as of right now that ADAL doesnt? The only sick patient is ADALJS/ADALAngular with near fatal symptoms when interfacing with ADFS. I hope the powers at MS are reading this.

@sameerag
Copy link
Member

sameerag commented Dec 7, 2019

@LastTribunal We are working on Angular release already, please check the project board angular for the progress. We are also working on samples improvements the remaining part of the year. We will follow up with an ADFS 2019 sample once Angular is available.

msal js adds support for v2 endpoints, combines support for school, work accounts, B2C etc, more details on this here. In msal js we also enhanced the API interface and new features which are not present in adal js.

The request to try msal-core meanwhile is to unblock those set of people who are already using msal-angular with custom improvements on the msal-core. Hope this clarifies the strategy.

Please note that ADFS on prem is not supported and we do not have line of sight on when that would be supported from microsoft client libraries.

@marisaoliva
Copy link

marisaoliva commented Dec 12, 2019

Hello:

I've seen that the version 1.2.0 support adfs, but only url microsoft? ¿Is possible use a url adfs private and use Msal?

I try do this but I've a error why the library try to redirect a url that it not the mine

@sameerag
Copy link
Member

Hi @marisaoliva We would need some time to address this as this would need some significant changes in our authority code which determines the end point to call for token acquisition. I am tagging this as a feature request and we will update the roadmap when we can invest on this.

@sameerag sameerag added the feature Feature requests. label Dec 14, 2019
@jasonnutter jasonnutter removed the core label Jan 10, 2020
@sameerag sameerag removed Issue Triage The engineering team has looked into the issue, understood the issue and classified the issue. question Customer is asking for a clarification, use case or information. labels Jan 20, 2020
@krytical
Copy link

krytical commented Apr 1, 2020

Hi @sameerag,

Just wondering if there is any update for MSAL and on-premise ADFS? We have a React application that would need ADFS access tokens and we got that working using react-adal, however, we're switching to MSAL as ADAL is not supported anymore.

Thanks!

@gaelian
Copy link

gaelian commented May 8, 2020

I'd also like to pile on this one. Considering that MSAL.NET supports direct connections to on-prem AD FS 2019+ (with some minor tweaking of generated JWTs, it turns out) I had more or less assumed that MSAL.js would also have similar support, until reading this issue. My colleagues and I would be very keen to see this becoming a reality so that we have similar approaches available for SPAs.

@LastTribunal
Copy link

I've been waiting for support from this so called MSAL team, all I got was empty promises and excuses. Wasted my time

@jasonnutter
Copy link
Contributor

Update: We expect to add support for ADFS 2019 in 1.4.0. Follow the above pull request for more. Sorry this took so long, appreciate the patience!

@tnorling tnorling linked a pull request Aug 17, 2020 that will close this issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2020
@jasonnutter jasonnutter added the adfs Related to ADFS label Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.