-
Notifications
You must be signed in to change notification settings - Fork 2.7k
ADFS 2019 Support #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADFS 2019 Support #1668
Conversation
This reverts commit 5197bc4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick otherwise LGTM, good work!
Co-authored-by: Jason Nutter <[email protected]>
This PR has not seen activity in 14 days. It may be closed if it remains stale. |
This PR has not seen activity in 14 days. It may be closed if it remains stale. |
This PR has not seen activity in 14 days. It may be closed if it remains stale. |
So is this resolved or not? |
@James-Randal ADFS 2019 is supported in [email protected]. If you have questions or find a bug please open a new issue. Thanks! |
This PR ports the changes in #1617 to msal-core and builds on #1582 and will close #99
Differences from AAD/B2C Authorities:
ClientInfo
, this PR buildsuid
from the subject claim on idToken insteadpreferred_username
, this PR sets this toupn
instead.well-known/openid-configuration
instead of2.0/.well-known/openid-configuration