Skip to content

[msal-common] Create account and authority folders #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 4, 2020
Merged

[msal-common] Create account and authority folders #1330

merged 4 commits into from
Mar 4, 2020

Conversation

sameerag
Copy link
Member

@sameerag sameerag commented Mar 2, 2020

This PR restructures existing msal-common code into account and authority folders. More changes will follow once this is merged.

@sameerag sameerag changed the base branch from dev to msal-node-base March 2, 2020 17:47
@sameerag sameerag mentioned this pull request Mar 2, 2020
Closed
1 task
jmckennon
jmckennon approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jmckennon jmckennon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

pkanher617
pkanher617 approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@pkanher617 pkanher617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be all formatting and name changes, lgtm.

@sameerag sameerag self-assigned this Mar 2, 2020
@sameerag sameerag merged commit 0b7f97c into msal-node-base Mar 4, 2020
@sameerag sameerag deleted the msal-node-account-authority-folders branch March 18, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkanher617 pkanher617 pkanher617 approved these changes

@jmckennon jmckennon jmckennon approved these changes

Assignees

@sameerag sameerag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sameerag @pkanher617 @jmckennon