Skip to content

[msal-node] add DEBUG logging #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 15, 2020
Merged

[msal-node] add DEBUG logging #1423

merged 19 commits into from
Apr 15, 2020

Conversation

sameerag
Copy link
Member

This PR adds npm debug to the existing logger to msal-node library

@sameerag sameerag mentioned this pull request Mar 26, 2020
1 task
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem like a lot of unrelated changes, but logger part looks good.

@sameerag
Copy link
Member Author

All changes are "prettify" induced linter changes. I will close on common rules soon to be able to get rid of these annoying diffs.

Copy link
Contributor

@sangonzal sangonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@sameerag
Copy link
Member Author

@sangonzal let me know when you are ready for me to merge this to your branch!

@sameerag sameerag changed the base branch from sagonzal/device-code to sagonzal/msal-node-tests April 3, 2020 02:17
@sameerag sameerag changed the base branch from sagonzal/msal-node-tests to msal-node-base April 10, 2020 00:18
@sameerag sameerag merged commit 65fb4a6 into msal-node-base Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants