Skip to content

[msal-common][msal-node] Authority changes #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 17, 2020
Merged

[msal-common][msal-node] Authority changes #1424

merged 20 commits into from
Apr 17, 2020

Conversation

sameerag
Copy link
Member

This PR fixes the authority type resolution runtime and adds B2CAuthority.ts:

  • B2C Authority extends the generic Authority class, rather than AADAuthority.
  • Added knownAuthorities config parameter which sets the trusted authorities for B2C use cases
  • Authority factory will create B2C Authority instance if knownAuthorities is set, AAD Authority instance otherwise; For ADFS we look for /adfs as the first path segment in the URL.

PRs #1276 and #1416 fix this for msal-core and msal-common (msal-browser based version)

@sameerag sameerag changed the base branch from dev to sagonzal/device-code March 26, 2020 05:15
@sameerag sameerag changed the base branch from sagonzal/device-code to msal-node-logging March 26, 2020 05:16
@sameerag sameerag mentioned this pull request Mar 26, 2020
Closed
1 task
tnorling
tnorling reviewed Mar 28, 2020
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 small comments but overall looks good

@sameerag sameerag changed the base branch from msal-node-logging to msal-node-network March 31, 2020 05:49
@sameerag sameerag changed the base branch from msal-node-network to msal-node-logging March 31, 2020 05:50
@sameerag sameerag changed the base branch from msal-node-logging to sagonzal/msal-node-tests April 3, 2020 02:16
@sameerag sameerag changed the base branch from sagonzal/msal-node-tests to msal-node-logging April 3, 2020 02:18
@sameerag sameerag mentioned this pull request Apr 9, 2020
Closed
tnorling
tnorling approved these changes Apr 10, 2020
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sameerag sameerag merged commit 1393392 into msal-node-logging Apr 17, 2020
@sameerag sameerag deleted the msal-node-authority branch May 4, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangonzal sangonzal sangonzal left review comments

@tnorling tnorling tnorling approved these changes

@pkanher617 pkanher617 pkanher617 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sameerag @tnorling @pkanher617 @sangonzal