-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[msal-node][msal-common] unit tests for msal-node changes #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please test the coverage please?
.gitignore
Outdated
@@ -255,6 +255,9 @@ paket-files/ | |||
.DS_Store | |||
.DS_Store? | |||
|
|||
# Visual Studio code | |||
.vscode/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like having this in the repo because it we can use to setup things like linting, etc in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok cool I'll remove this from .gitignore
…checks [msal-node] Switch strictNullChecks: true for msal-node
Corresponding tests for #1434