[msal-core] Fix circular dependency for B2C Authority #1479
Conversation
tnorling
commented
Apr 8, 2020
tnorling
commented
- Moves B2CTrustedHostList to B2cAuthority class to fix circular dependency with AuthorityFactory
| @@ -6,7 +6,8 @@ | |||
| import { Authority } from "./Authority"; | |||
| import { AuthorityType } from "./Authority"; | |||
| import { ClientConfigurationError } from "../error/ClientConfigurationError"; | |||
| import { AuthorityFactory, B2CTrustedHostList } from "./AuthorityFactory"; | |||
|
|
|||
| export const B2CTrustedHostList: object = {}; | |||
There was a problem hiding this comment.
So we want this to be a list or an array?? How are we parsing user i/p? You may have mentioned it, but I want to make sure we don't get type compat issues later.
There was a problem hiding this comment.
So in core I made this a dictionary to remain consistent with the AADTrustedHostList and to allow for flexibility to combine the AAD and B2C Authorities if that becomes the direction in the future. In msal-common this will be a list. The user facing knownAuthorities is a list in both core and common and setKnownAuthorities will populate the trusted host list slightly differently in both to account for the differences in type
There was a problem hiding this comment.
I agree this is a little confusing and I dont think dict is really the right type for either AAD or B2C but I think consistency is more important. If we want to change this for core we can discuss offline and open a separate PR
