[msal-node][msal-common] Update generation of client info headers #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangonzal
requested review from
jasonnutter,
DarylThayil,
tnorling,
pkanher617 and
sameerag
sangonzal
commented
Apr 9, 2020
sangonzal
commented
Apr 9, 2020
| @@ -1,30 +1,31 @@ | |||
| { | |||
There was a problem hiding this comment.
Only relevant change here is the addition of "resolveJsonModule": true. (I also fixed the indentation, and thus the big diff)
sameerag
reviewed
Apr 9, 2020
sameerag
reviewed
Apr 9, 2020
sangonzal
changed the title
15 tasks
sangonzal
changed the base branch from
sagonzal/msal-node-strict-null-checks
to
msal-node-base
pkanher617
reviewed
Apr 14, 2020
pkanher617
reviewed
Apr 14, 2020
pkanher617
suggested changes
Apr 14, 2020
pkanher617
approved these changes
Apr 27, 2020
Clean up imports in msal-common tests
…node-refresh-flow
…AzureAD/microsoft-authentication-library-for-js into sagonzal/msal-node-refresh-flow
[msal-node][msal-commmon] Add support for acquiring tokens with a refresh token to msal-node
azure-pipelines bot
pushed a commit
to pkanher617/microsoft-authentication-library-for-js
that referenced
this pull request
Jan 4, 2022
…lt-headers [msal-node][msal-common] Update generation of client info headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the generation of the client info headers from msal-common into msal-node. If these values are not passed in from msal-node (or from whoever is calling into msal-common), then we fall back to generating them in common.
Client info headers: