[msal-node] Cache-5: Msal node cache additional changes for end-to-end cache to work #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l generation code
sangonzal
approved these changes
Apr 23, 2020
Comment on lines
+12
to
+13
| * @param key | ||
| * @param value |
There was a problem hiding this comment.
nit: getSerializedCache() doesn't have parameters.
There was a problem hiding this comment.
Intentional. It is a getter to avoid access to private variables.
There was a problem hiding this comment.
We should remove the comments here.
pkanher617
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR in the series of cache PRs and works end-to-end, reads a
jsonfile from the disk, retrieves tokens from the server and appends the newly minted ones to thejsonfile in the disk.Notable changes:
NodeStorageupdate for read/write from the cacheNote: Most of the diff for this PR is
linterdiff; will be trying to minimize this soon by updating thetsdxlint rules to not cause so much disruption for line length which accounts to most changes.