[msal-common][msal-node] Move authority generation from common to node #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangonzal
requested review from
jasonnutter,
DarylThayil,
tnorling,
pkanher617 and
sameerag
added 2 commits
April 24, 2020 11:59
sameerag
reviewed
Apr 24, 2020
DarylThayil
approved these changes
Apr 30, 2020
tnorling
reviewed
May 4, 2020
jasonnutter
reviewed
May 4, 2020
pkanher617
reviewed
May 4, 2020
pkanher617
reviewed
May 4, 2020
pkanher617
reviewed
May 4, 2020
pkanher617
suggested changes
May 4, 2020
sangonzal
commented
May 6, 2020
pkanher617
approved these changes
May 6, 2020
sameerag
reviewed
May 7, 2020
sameerag
approved these changes
May 7, 2020
added 2 commits
May 12, 2020 15:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves authority creation from msal-common to msal-node. Instead of creating an authority for every client, we now just create one per application object, and pass this in to msal-common.