Skip to content

clean up auth code sample a little #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2020
Merged

clean up auth code sample a little #1641

merged 1 commit into from
May 12, 2020

Conversation

DarylThayil
Copy link
Contributor

Cleaned up the auth code sample a little to be a little more idiomatic to what an express app looks like.

sangonzal
sangonzal approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@sangonzal sangonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

sameerag
sameerag approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Eventually we may also want to write code with "await" and "async".

@coveralls
Copy link

coveralls commented May 12, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 79.554% when pulling 82382c8 on auth-sample-clean into ba66362 on dev.

@hectormmg
Copy link
Member

LGTM!

@DarylThayil
Copy link
Contributor Author

@jasonnutter feedback resolved.
Added same build scripts to device code as well, no sample updates made there

@DarylThayil DarylThayil merged commit 1ee80e0 into dev May 12, 2020
@tnorling tnorling deleted the auth-sample-clean branch October 6, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter left review comments

@sameerag sameerag sameerag approved these changes

@sangonzal sangonzal sangonzal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DarylThayil @coveralls @hectormmg @jasonnutter @sameerag @sangonzal