[msal-node] Cache Lookup - 3: Msal node cache response #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
changed the title
sangonzal
approved these changes
May 20, 2020
| }; | ||
|
|
||
| constructor() { | ||
| this.cachePath = ""; | ||
| this.cachePath = ''; |
There was a problem hiding this comment.
Do we need cachePath anymore?
There was a problem hiding this comment.
We don't if we have keyTar working as path is calculated. Also I think Daryl's PR makes this unnecessary. I can pull dev and change this.
lib/msal-node/src/cache/Storage.ts
Outdated
| private inMemoryCache: InMemoryCache; | ||
|
|
||
| constructor(cacheConfig: CacheOptions) { | ||
| this.cacheConfig = cacheConfig; | ||
| if (this.cacheConfig.cacheLocation! === "fileCache") | ||
| if (this.cacheConfig.cacheLocation! === 'fileCache') |
There was a problem hiding this comment.
Indication we are using application cache by the user: extension or otherwise instead of just inMemoryCache. Ideas welcome.
pkanher617
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
ResponseHandler.ts, introducesCacheRecord.