Skip to content

Extend acquireTokenHelper instrumentation #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 11, 2020
Merged

Extend acquireTokenHelper instrumentation #1752

merged 16 commits into from
Jun 11, 2020

Conversation

jo-arroyo
Copy link
Collaborator

This PR adds instrumentation through logger messages to acquireTokenHelper for msal-core.

@github-actions github-actions bot added the [email protected] Related to [email protected] (implicit flow) label Jun 5, 2020
@coveralls
Copy link

coveralls commented Jun 5, 2020

Coverage Status

Coverage increased (+0.04%) to 76.805% when pulling 983087b on ath-instrumentation into 2c40f1e on dev.

@jo-arroyo jo-arroyo marked this pull request as ready for review June 8, 2020 20:04
Copy link
Member

@hectormmg hectormmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jo-arroyo jo-arroyo merged commit b3a7636 into dev Jun 11, 2020
@jo-arroyo jo-arroyo deleted the ath-instrumentation branch June 11, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[email protected] Related to [email protected] (implicit flow)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants