Skip to content

[msal-node] SilentFlow node interface #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 1, 2020
Merged

[msal-node] SilentFlow node interface #1809

merged 18 commits into from
Jul 1, 2020

Conversation

sameerag
Copy link
Member

@sameerag sameerag commented Jun 22, 2020 •
edited
Loading

This PR adds support for:

  • acquireTokenSilent in msal-node
  • getAccounts() and removeAccount support in msal-node/CacheManager.ts
  • Sample for silent flow

Things to note:

  • Unit tests for Storage.ts are not added as a follow up PR will change the functionality.
  • Unit tests for TokenCache.ts are in the pipeline and will be a separate PR

@github-actions github-actions bot added the msal-node Related to msal-node package label Jun 22, 2020
@sameerag sameerag marked this pull request as draft June 22, 2020 18:57
@sameerag sameerag changed the base branch from serialize-deserialize to dev June 23, 2020 20:11
@coveralls
Copy link

coveralls commented Jun 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 79.493% when pulling 98ce968 on msal-node-silent-flow-client into 8ec2586 on dev.

@sameerag sameerag changed the base branch from dev to sagonzal/fix-merge-bug June 24, 2020 00:24
@sameerag sameerag changed the base branch from sagonzal/fix-merge-bug to dev June 24, 2020 00:25
@sameerag sameerag mentioned this pull request Jun 24, 2020
Closed
1 task
@github-actions github-actions bot added the samples Related to the samples apps for the library. label Jun 30, 2020
@sameerag sameerag marked this pull request as ready for review June 30, 2020 17:49
sangonzal
sangonzal suggested changes Jun 30, 2020
View reviewed changes
@github-actions github-actions bot added the msal-common Related to msal-common package label Jun 30, 2020
pkanher617
pkanher617 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@pkanher617 pkanher617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the port but otherwise lgtm

jasonnutter
jasonnutter approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing otherwise looks good!

@sameerag sameerag merged commit c1ff9e1 into dev Jul 1, 2020
@sameerag sameerag mentioned this pull request Jul 1, 2020
Closed
1 task
@sameerag sameerag deleted the msal-node-silent-flow-client branch July 20, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangonzal sangonzal sangonzal approved these changes

@jasonnutter jasonnutter jasonnutter approved these changes

@pkanher617 pkanher617 pkanher617 approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

Assignees
No one assigned
Labels
msal-common Related to msal-common package msal-node Related to msal-node package samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sameerag @coveralls @jasonnutter @pkanher617 @sangonzal