Add custom authority lookup #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
DarylThayil,
jasonnutter,
jmckennon,
jo-arroyo,
pkanher617,
sameerag and
hectormmg
as code owners
github-actions
bot
added
the
[email protected]
jasonnutter
approved these changes
Jun 26, 2020
pkanher617
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Instance Discovery changes in #1582 I removed the Instance Discovery call using the developer provided authority, in favor of the default authority. This PR reverts to using the provided authority as all other aliases are still included in the response. This is mainly to prevent a breaking change for custom domains such as
login.windows-ppe.netthat will not show up in the initial instance discovery call.