Skip to content

Update sample folder structure #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 30, 2020
Merged

Update sample folder structure #1855

merged 9 commits into from
Jun 30, 2020

Conversation

pkanher617
Copy link
Contributor

This PR is based off of feedback received in #1841 that samples are becoming numerous. Now we have parent folders for each package that will have the respective samples in that folder.

@pkanher617 pkanher617 changed the base branch from dev to extrascopes-append-error-2.0 June 29, 2020 21:02
@github-actions github-actions bot added the samples Related to the samples apps for the library. label Jun 29, 2020
@github-actions github-actions bot added the msal-browser Related to msal-browser package label Jun 29, 2020
@github-actions github-actions bot added msal-common Related to msal-common package msal-node Related to msal-node package labels Jun 29, 2020
jasonnutter
jasonnutter approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you confirm lerna still works correctly?

@pkanher617 pkanher617 changed the base branch from extrascopes-append-error-2.0 to dev June 30, 2020 17:31
@pkanher617
Copy link
Contributor Author

Did you confirm lerna still works correctly?

Had to update lerna.json, thanks for catching this.

@coveralls
Copy link

coveralls commented Jun 30, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 79.246% when pulling 9345d13 on sample-folders-change into 53fc3fc on dev.

@pkanher617 pkanher617 merged commit ec094d8 into dev Jun 30, 2020
@pkanher617 pkanher617 deleted the sample-folders-change branch October 2, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@tnorling tnorling tnorling approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkanher617 @coveralls @jasonnutter @tnorling