Skip to content

Cache cleanup v2 #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 30, 2020
Merged

Cache cleanup v2 #1856

merged 5 commits into from
Jun 30, 2020

Conversation

pkanher617
Copy link
Contributor

This PR fixes cache items not being cleaned in certain scenarios:

  • When a silent iframe call failed
  • When the back button is used in a redirect flow
  • When the handleRedirectPromise() function is not used

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package samples Related to the samples apps for the library. labels Jun 29, 2020
@pkanher617 pkanher617 changed the base branch from sample-folders-change to dev June 30, 2020 20:12
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.437% when pulling 1e9a858 on cache-cleanup-v2 into ec094d8 on dev.

@pkanher617 pkanher617 merged commit de65864 into dev Jun 30, 2020
@pkanher617 pkanher617 deleted the cache-cleanup-v2 branch October 2, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@tnorling tnorling tnorling approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package samples Related to the samples apps for the library.
Projects
None yet
Milestone
@azure/[email protected] - GA Release
Development

Successfully merging this pull request may close these issues.
4 participants
@pkanher617 @coveralls @jasonnutter @tnorling