Skip to content

[msal-node] Update silent flow sample UI #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 7, 2020
Merged

[msal-node] Update silent flow sample UI #1888

merged 15 commits into from
Jul 7, 2020

Conversation

hectormmg
Copy link
Member

@hectormmg hectormmg commented Jul 2, 2020 •
edited
Loading

This PR:

  • Adds a user interface to the msal-node-silent-flow sample application
  • Adds and uses express-handlebars to make the sample's UI dynamic
  • Adds a Microsoft Graph request in the form of a "See profile" button and flow for parity with other samples
  • Renames the data/cache.json file to data/example.cache.json and updates instructions in index.js comments to make it clear that the developer needs to provide their own valid cache file for the sample to work.

@github-actions github-actions bot added the samples Related to the samples apps for the library. label Jul 2, 2020
@coveralls
Copy link

coveralls commented Jul 2, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 80.98% when pulling 0a04662 on node-silent-samples into c560890 on dev.

@hectormmg hectormmg marked this pull request as ready for review July 6, 2020 22:43
@pkanher617
Copy link
Contributor

pkanher617 commented Jul 6, 2020 •
edited
Loading

Can we remove the msal-node- prefix from all the folder names in the msal-node-samples folder? It can look like this now:

  • msal-node-samples
    • silent-flow
    • auth-code
    • device-code
    • refresh-token

pkanher617
pkanher617 approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@pkanher617 pkanher617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment about folder names.

sangonzal
sangonzal approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@sangonzal sangonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hectormmg hectormmg merged commit ae0d2bd into dev Jul 7, 2020
@hectormmg hectormmg mentioned this pull request Jul 7, 2020
Closed
@hectormmg hectormmg deleted the node-silent-samples branch July 7, 2020 00:59
@sameerag sameerag mentioned this pull request Jul 7, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkanher617 pkanher617 pkanher617 approved these changes

@sangonzal sangonzal sangonzal approved these changes

@DarylThayil DarylThayil Awaiting requested review from DarylThayil

@jasonnutter jasonnutter Awaiting requested review from jasonnutter

@jmckennon jmckennon Awaiting requested review from jmckennon

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

Assignees
No one assigned
Labels
samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hectormmg @coveralls @pkanher617 @sangonzal