-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add Beachball to Repo #2 #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beachball to Repo #2 #2113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but approved! Excited for this!
@@ -0,0 +1,3 @@ | |||
{ | |||
"shouldPublish": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to ignore the samples folder completely so we don't have to add this to every sample?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to use the path config but beachball is currently overwriting the path config parameter with cwd
so until they fix their config we need to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a ticket here: microsoft/beachball#377
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a description of what the release process looks like after this is merged in, as it's hard to deduce from the config files.
We should also be careful going forward to always include this
{
"shouldPublish": false
}
into any samples.
Example of what is added to the changelog for a minor version change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
How it works:
beachball publish
command is run, which reviews the changefiles for the highest order release (i.e. major, minor, patch), then bumps the package versions and their dependency versions accordingly, and finally performs the publish.